Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pysa][MLH] Hide model verification error for "X is not part of the environment" #871

Open
arthaud opened this issue May 31, 2024 · 0 comments

Comments

@arthaud
Copy link
Contributor

arthaud commented May 31, 2024

When running the open source version of pysa on a codebase, we see a lot of errors such as:

`rest_framework.request.Request.POST` is not part of the environment, no module `rest_framework` in search path.
`aiohttp.client.ClientSession.get` is not part of the environment, no module `aiohttp` in search path.
[...]

This is because we have models (sources and sinks) for many libraries, and we error if we don't find the modeled function or method.
We want to preserve that behavior internally at Meta, because such errors are usually indicating a problem in the configuration.
This is different for open source, we don't expect a given corebase to use all libraries annotated by Pysa.

To prevent this, the idea would be to hide model verification errors of the form "X is not part of the environment" when a given option is provided, either via a command line flag, or better, via a configuration file (such as a taint.config file or the .pyre_configuration file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant