Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading changes #1115

Open
19 tasks done
Robinlovelace opened this issue Sep 23, 2024 · 23 comments · Fixed by #1116, #1122, #1123 or #1129
Open
19 tasks done

Proofreading changes #1115

Robinlovelace opened this issue Sep 23, 2024 · 23 comments · Fixed by #1116, #1122, #1123 or #1129
Assignees

Comments

@Robinlovelace
Copy link
Collaborator

Robinlovelace commented Sep 23, 2024

  • Foreword (2nd Edition): RL
  • Preface: RL
  • 1 Introduction: RL, JM, JN
  • 2 Geographic data in R: RL
  • 3 Attribute data operations: RL
  • 4 Spatial data operations: RL
  • 5 Geometry operations: JM
  • 6 Raster-vector interactions: JN
  • 7 Reprojecting geographic data: JN
  • 8 Geographic data I/O: JN
  • 9 Making maps with R: JN
  • 10 Bridges to GIS software: JN
  • 11 Scripts, algorithms and functions: JM
  • 12 Statistical learning: JM
  • 13 Transportation: RL
  • 14 Geomarketing: JM
  • 15 Ecology: JM
  • 16 Conclusion: RL, JM, JN
  • References: RL, JM, JN
@Nowosad
Copy link
Member

Nowosad commented Sep 24, 2024

Chapters 6, 7, and 8 are done: #1119, #1120, #1121. I plan to work on Chapters 9 and 10 tomorrow.

@Nowosad
Copy link
Member

Nowosad commented Sep 25, 2024

Chapters 9 and 10 are done: #1125, #1126

Edit: also Chapter 16: #1127

@Nowosad
Copy link
Member

Nowosad commented Sep 25, 2024

There are two remaining issues:

  1. Several times, the comment is "AU: Please move this line of text to the next page" -- is seems like a lost battle, as when we move one line, then another problematic lines could occur)
  2. References also contain some comments from the proof reader

@Robinlovelace
Copy link
Collaborator Author

AU isn't for us I think.

@jannes-m
Copy link
Collaborator

I plan to start the proof-reading today in the evening. @Robinlovelace I would start with the chapters that are solely assigned to me. When I am done with those, I'll also have a look at jointly assigned chapters.

@jannes-m
Copy link
Collaborator

The reviewer points out (ch5):

Is it OK that you are spelling "gray" with an "a" here but "grey" with an "e" in the code below? Please do a global search for the word you wish to change (if you decide to do so).

I guess he has a point here, if you agree I would replace all instances of grey (BE) by gray (AE).

@jannes-m
Copy link
Collaborator

c5 in #1128

@Robinlovelace
Copy link
Collaborator Author

I guess he has a point here, if you agree I would replace all instances of grey (BE) by gray (AE).

Agreed.

@Robinlovelace Robinlovelace linked a pull request Sep 28, 2024 that will close this issue
@Robinlovelace Robinlovelace reopened this Sep 28, 2024
This was referenced Sep 28, 2024
@jannes-m
Copy link
Collaborator

jannes-m commented Oct 2, 2024

c12 is done in #1136

@Robinlovelace
Copy link
Collaborator Author

Great job, thanks Jannes! See a couple of comments in there, looking great.

@Robinlovelace
Copy link
Collaborator Author

How are the references looking now @Nowosad, almost done, right?

@Robinlovelace
Copy link
Collaborator Author

Then it's just one more chapter, you're down for that @jannes-m, and we're good to go. Is #1137 ready to merge yet also?

@jannes-m
Copy link
Collaborator

jannes-m commented Oct 4, 2024

I will finish the review of my last two chapters this weekend!

@Nowosad
Copy link
Member

Nowosad commented Oct 4, 2024

@Robinlovelace I tried to fix all of the references a few days ago

@Robinlovelace
Copy link
Collaborator Author

@Robinlovelace I tried to fix all of the references a few days ago

@Nowosad were you were successful?

We can check another one of the check boxes above if so.

@Nowosad
Copy link
Member

Nowosad commented Oct 4, 2024

Hi @Robinlovelace -- I just rendered a new pdf, I looked at the all of the references, and made a few edits on Zotero. Please reexport the bib file and then the references should be fine.

@Robinlovelace
Copy link
Collaborator Author

See 589a7e6 there are a couple of additional tweaks I'd like to make but this is basically done.

@Nowosad
Copy link
Member

Nowosad commented Oct 4, 2024

Great -- thanks!

@jannes-m
Copy link
Collaborator

jannes-m commented Oct 4, 2024

#1137 and #1139 are ready for review

@Robinlovelace
Copy link
Collaborator Author

All good and merged. @jannes-m and @Nowosad I've emailed you. We should be able to close this issue Tuesday, after submitting the updated post-proofreading changes. Almost there 🚀

@Nowosad
Copy link
Member

Nowosad commented Oct 7, 2024

Hi @Robinlovelace I just have about 10 minutes, and started skimming thorough the pdf:

  1. Page 227: "the simple ‘lifeApp’ example (Figure ??)" -- this seems to be the only ?? issue
  2. Page 352: something is wrong with the italics

Nowosad added a commit that referenced this issue Oct 7, 2024
github-actions bot pushed a commit that referenced this issue Oct 7, 2024
@Nowosad
Copy link
Member

Nowosad commented Oct 7, 2024

I think I fixed the both issues.

@Robinlovelace
Copy link
Collaborator Author

You're ahead of the game, thanks Jakub as was just about to work on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment