Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Income shown on Match page is 1.4x lower than the income shown in game client #42

Open
dsjoerg opened this issue Apr 28, 2016 · 1 comment

Comments

@dsjoerg
Copy link
Member

dsjoerg commented Apr 28, 2016

For example in this match: http://ggtracker.com/matches/6617852
income at 3:35 is 1147 for Terran, 1091 for Protoss in the in-game income tab.
However on the GGTracker match page it shows as 823 for both of them.

The reason for this is that internally we store the income as 823 (which is the HotS-style income) but when showing things to users of course we should show them as LotV-style.

Or of course we could actually change our internal data representation to be LotV-style, but that would involve making additional changes throughout the codebase.

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 28, 2016

Same goes for gas income, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant