Appendix: Legend does not correspond to colours used for same license and copyright notice

[mschoettle]

The appendix uses different colour tones for the columns "same license" and "license and copyright notice".

However, in the legend on the bottom the same blue-ish colour tone is used for all items of those categories. It would be good to match what is used in the table.

[mlinksva]

I see the same used for both columns:

Could you clarify?

[mschoettle]

Thanks for the quick response. I should have added a screenshot in the issue right away.

See the different colour tones used in the "same license" column.

The legend, however, looks as follows:

Another small issue is that the same darker colour tone is used for "same license (file)" and "same license (library)" although that might be intended?

[mlinksva]

Yes the muted colours are intended for lighter versions of conditions. They should be used in the key, thanks for noticing this discrepancy!

[mlinksva]

Looks like the reason is there's a bit of special handling of conditions with -- in their name only in the appendix table, should be in the key/legend as well. And probably elsewhere, but a start would be to make this page consistent.

choosealicense.com/appendix.md

Lines 45 to 52 in 05070e5

	{% if r contains "--" %}
	{% assign lite = " lite" %}
	{% else %}
	{% assign lite = "" %}
	{% endif %}
	<span class="{{ r | append: lite }}" style="margin: auto;">
	<span class="license-sprite {{ r }}"></span>
	</span>

A pull request to fix would be welcome, or I'll get to it eventually.

[mschoettle]

Thanks! I will see if I can create a PR for it.

Would it be ok to also add a third colour (in a separate PR) for "same license" so that each of the three are represented by a different one?

[mlinksva]

Great!

Not sure I understand what you have in mind re adding a third colour. My intent is to have all conditions be blue, but lighter versions of conditions be a muted blue. Do you have a different scheme in mind?

[mschoettle]

Ah, I see.

The issue I faced when reviewing differences between licenses was that "same license" has three different versions and only two different colours. The difference in "same license (file)" and "same license (library)" is very minimal so that it was difficult to figure out which of the two the darker dot belonged to. That's why I propose to introduce a third muted blue.

Additionally, I think it could be helpful to add the rule label to the tooltip, and the type to the legend in order to not have to rely on colour alone.

[mlinksva]

Thanks for those PRs! Fine with me to include the rule label in the tooltip.

I think different shades for each variation would be hard to discern unless you really know what you're looking for.

[mlinksva]

After merging I noticed a small issue with each of the two PRs, left a comment and review comment. In case you're inspired to look, please do, otherwise I will eventually.

[mschoettle]

After merging I noticed a small issue with each of the two PRs, left a comment and review comment. In case you're inspired to look, please do, otherwise I will eventually.

Thanks for merging and sorry about that. I'll have a look.

Thanks for those PRs! Fine with me to include the rule label in the tooltip.

I think different shades for each variation would be hard to discern unless you really know what you're looking for.

Yes, that's true. Adding the rule label in the tooltip would alleviate this anyway.

Any suggestions on where to add it specifically? I tried the following:

[mlinksva]

Seems like a fine place, though two :s are ugly. Maybe Same license (library) condition: or even elide condition if latter isn't easy?

[mschoettle]

Great idea! It's actually easy and works with all types based on a quick look.

PR that adds the label and fixes the tooltips is coming.

For the second issue I have to look a bit more.