-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote paths #127
Comments
Yeah, that was a mistake! Vinyl should absolutely support any kind of URL/path - A PR w/ some tests to prevent this in the future would be great |
This is a hard problem to solve because we need to normalize filesystem paths. There needs to be a module created that determines if a path is fs or remote. |
PR submitted: #128 |
Copying my comment from #128 PR: I actually believe this problem can and should be solved by my idea of an Enhanced Stat Object (#105). Usage would look something like: var file = new Vinyl({
path: 'http://google.com',
stat: {
isRemote: true
}
}) The |
First I would like to thank you for your work on this module.
Version 2 brought some internal changes which prevent the use of vinyl for remote objects.
Prior to v2 it was possible to store an url as path. The use of
path.normalize
introduced in v2 breaks this "feature" ;)Is this the intended behaviour or would you accept a PR to "fix" this?
The text was updated successfully, but these errors were encountered: