Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

MLP Custom Fields are visible in post types even where MLP support is not active #310

Open
mayeenulislam opened this issue Jul 25, 2018 · 5 comments

Comments

@mayeenulislam
Copy link

The following MLP Custom Fields are visible everywhere. Even I did not activated Translation Support in some custom post types, but the fields are visible there too.

  • Translation completed
  • Send all the translations to trash when this post is trashed.

See, sliders are excluded in support:

sliders-are-excluded

But the fields are there:

mlp-slider-meta-fields

Version Information

  • WordPress: 4.9.7
  • MultilingualPress: 2.11.1

Steps to Reproduce

  1. Exclude a post type by unchecking them from Network Admin > Settings > MultilingualPress > Custom Post Type Translator Settings
  2. Save changes
  3. Now add a new post on that particular post type, and see the fields are there

What I Expected

The fields shouldn't be there.

What Happened Instead

The fields are there without any need.

@mayeenulislam
Copy link
Author

mayeenulislam commented Jul 25, 2018

Just not to clutter issues, the Translation completed checkbox have no impact. If I check this, after refresh it din't stay checked.

checking-translation-completed-not-working

@widoz
Copy link
Member

widoz commented Jul 28, 2018

Hi @mayeenulislam

I created a branch bug/310 that should fix this issue, also I guess we have to consider to prevent those action when a post is saved even if we don't show the checkboxes.

cc @Dinamiko

@mayeenulislam
Copy link
Author

Thank you @widoz and @Dinamiko
I cloned the repo and checked out to the bug/310 branch, then copied all the files from src/ and replaced my current files in plugins/multilingual-press/ (delete + paste).

I found the meta fields are not visible in inactive post types, but they are present in active post types. I think the branch at current state solved the issue.


PS: But the issue reported with a GIF in the comment is not resolved yet.

@widoz
Copy link
Member

widoz commented Jul 30, 2018

Hi @mayeenulislam,

Glad the branch fix the issue, for the other one can you open a different issue so we can create another branch and dicuss there the problem?

@mayeenulislam
Copy link
Author

Sure, that would be better. Branching per issue.
I love the plugin. ❤️ Otto (Fuxia) introduced me with it. Will definitely report other issues differently.
Keep up the good work. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants