Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Standardize actually be an Imputor #77

Closed
rofinn opened this issue Oct 10, 2020 · 0 comments · Fixed by #87
Closed

Should Standardize actually be an Imputor #77

rofinn opened this issue Oct 10, 2020 · 0 comments · Fixed by #87
Milestone

Comments

@rofinn
Copy link
Member

rofinn commented Oct 10, 2020

Standardize was introduced in #69, but it's unclear if it should be considered an imputor. It does fit most of the API of not erroring or changing the size of the input data and just modifying values, but it technically produces more missings and the result may have a different eltype if the input data doesn't allow missings.

@rofinn rofinn mentioned this issue Oct 10, 2020
10 tasks
@rofinn rofinn added this to the 0.6 milestone Oct 21, 2020
@rofinn rofinn closed this as completed in #87 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant