Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Expect redbean to support websocket #439

Open
lost22git opened this issue Jun 22, 2022 · 7 comments
Open

[FR] Expect redbean to support websocket #439

lost22git opened this issue Jun 22, 2022 · 7 comments
Labels
accepted We intend to address this issue.

Comments

@lost22git
Copy link

No description provided.

@jart
Copy link
Owner

jart commented Jun 23, 2022

I agree. Redbean should support websockets. It's something we don't have planned immediately but we certainly intend to do it in the not too distant future.

@jart jart added the accepted We intend to address this issue. label Jun 23, 2022
@javajosh
Copy link

javajosh commented Aug 31, 2022

I am also quite interested in websocket support. Any leads on this in terms of libraries? Or do you intend to implement something in the redbean.c file?

@jart
Copy link
Owner

jart commented Sep 4, 2022

We intend to implement it since the mechanics of websockets are pretty deeply intertwined with the workings of a web server. If there's any off the shelf helpers we can use for some key aspects of it, then we'd use them. But overall the process is just drilling through the RFC and writing tests.

@javajosh
Copy link

javajosh commented Sep 4, 2022

Today I've forked and built jart/cosmopolitan, started reading through redbean.c and also rfc6455.txt (each of which, interestingly enough, are about 7k lines). I have little experience with c, but I find the code quite readable. Justine, can you recommend any resources that might proactively ease my pain with c and its tooling, especially debugging with gdb? TIA

@jart
Copy link
Owner

jart commented Sep 4, 2022

Join our Discord #help channel and I'll mentor you in the art of C. Like you I have a background in Java (particularly Guava) so I could draw upon some of that experience to help clarify anything you need. https://discord.gg/FunsGsDG

@JakeBamrah
Copy link

JakeBamrah commented Feb 11, 2024

Forgive me if this i a naïve question here. I've been looking into this (along with RFC6455) for the last few days. I am a beginner C programmer but would love to give this a shot (although I think it will take a few months). Could this be broken down into two sub-tasks:

  1. Implementing websocket logic, apis and tests
  2. Then integrating it into redbean and greenbean

or should these two tasks be worked on in tandem?

Edit: I see from jart's comment above that the websocket implementation can be tightly coupled with the server itself. Can I ask how the mechanics of websockets would be intertwined with the workings of the webserver? This might be too big of a question to answer but even an example would help me to understand this statement a little better.

@pkulchenko
Copy link
Collaborator

@JakeBamrah, there is an implementation being worked on in #967, so you may want to review and discuss it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted We intend to address this issue.
Projects
None yet
Development

No branches or pull requests

5 participants