Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample.lua doesn't support bytes output #221

Open
ChristianRomberg opened this issue Apr 28, 2018 · 0 comments · May be fixed by #222
Open

sample.lua doesn't support bytes output #221

ChristianRomberg opened this issue Apr 28, 2018 · 0 comments · May be fixed by #222

Comments

@ChristianRomberg
Copy link

Hi,
first of all, thank you for this great project. It gives me as someone who hasn't studied machine learning the option to do some pretty nice text generation.
I trained the network on some binary data. It seems to work pretty well, or at least the loss is decreasing. Now, when I try to run sample.lua, it will give me the ordinal numbers with square brackets around it (like stored in the json file) instead of its binary counterparts.
I'm going to try to fix it myself, but I'm not a lua expert at all so I might need some help.

Also, as a feature request: What do you think about adding infinite sampling output?

@ChristianRomberg ChristianRomberg linked a pull request Apr 28, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant