Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerComponent in MRML? #483

Open
murphycw opened this issue Oct 25, 2024 · 3 comments
Open

registerComponent in MRML? #483

murphycw opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@murphycw
Copy link

MJML has a registerComponent function. Does MRML have an analogous function? I did trying looking. Apologies if I missed it. If not, do you have a recommendation for using custom components with MRML? Thanks!

@jdrouet
Copy link
Owner

jdrouet commented Oct 26, 2024

Hey!

Thanks for your interest in MRML!
Unfortunately, right now, it's not possible to implement your own component in MRML.
In the meantime, if your component can be split into known components/elements, you can use mj-include instead.

I'll start thinking about it though.

@jdrouet jdrouet added the enhancement New feature or request label Oct 26, 2024
@jdrouet jdrouet self-assigned this Oct 26, 2024
@jdrouet
Copy link
Owner

jdrouet commented Oct 27, 2024

To get more into details about this. Right now, all the components are built on top of enums. Which means there is no dyn components, which avoids the use of a dynamic table, which improves the performances by a lot.
Having a way to register components would imply a degradation of the performance.
I will create a poc for that and see if I can make a feature for that so that it's an opt in... I'll keep thinking about it...

@christopher-w-murphy
Copy link

Thanks for the update and for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants