Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item lists rendered as task list #220

Closed
nthiery opened this issue Feb 24, 2024 · 7 comments
Closed

Item lists rendered as task list #220

nthiery opened this issue Feb 24, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@nthiery
Copy link

nthiery commented Feb 24, 2024

I just noticed that, with jupyterlab-myst 2.3.1, itemized list are (systematically?) rendered as task list.

How to reproduce

  • Start jupyterlab with myst >= 2.3.0 installed

    E.g.: click the binder button from the documentation. Be patient until it starts. In a terminal, run pip install jupyterlab-myst==2.3.1. Reload page.

    Do we have a jupyterlite under hand with the latest jupyterlab-myst available for this kind of quick tests?

  • Create a new cell with the following content

    - foo
    - bar
    
  • Render the cell.

Expected

An itemized list

Got

A task list

Note

  • Reverting to 2.3.0 has no effect. Reverting to 2.1.0 fixes that issue
  • This does not happen in the sandbox on mystmd.org.
@nthiery nthiery added the bug Something isn't working label Feb 24, 2024
@jeremy886
Copy link

I also had the same problem and needed to downgrade to 2.1.0 to fix this.

@parmentelat
Copy link

same here - thanks for pointing out the working version !

in my case I also have upgraded to jlab 4.1.x; I'm pointing it out because I have seen a few extensions break with 4.1.x, so that's an angle that might be worth exploring too.

@agoose77
Copy link
Collaborator

Thanks all! I'll look into this!

@rowanc1
Copy link
Member

rowanc1 commented Feb 26, 2024

Very curious @agoose77 at what the problem is, I don't think that we changed anything in this area of the code, so it could be something external we are reacting to. Note that we do have a dependency for the task-lists parsing, and if that was unpinned or upgraded, there could be something going on in there (we post process, and if the internals changed that could be it).

@tavin
Copy link
Contributor

tavin commented Feb 28, 2024

#223

@agoose77
Copy link
Collaborator

Closed by #223

@parmentelat
Copy link

this is a very visible issue with our students setups, it would help a lot if that fix could be made shortly part of the latest pypi version... thanks in any case !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants