Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus counter metrics for asyncWorker , which like metrics of controller-runtime repository #5791

Open
CharlesQQ opened this issue Nov 6, 2024 · 1 comment · May be fixed by #5817
Open

Add prometheus counter metrics for asyncWorker , which like metrics of controller-runtime repository #5791

CharlesQQ opened this issue Nov 6, 2024 · 1 comment · May be fixed by #5817
Assignees
@CharlesQQ
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CharlesQQ
Copy link
Contributor

CharlesQQ commented Nov 6, 2024 •
edited
Loading

What would you like to be added:
asyncWorker lacks necessary metrics. These metrics will be created and updated in controller_runtime reconcile; but asyncWorker lacks similar info.

The following metrics should be added:

  • controller_runtime_reconcile_total
  • controller_runtime_reconcile_errors_total
  • controller_runtime_terminal_reconcile_errors_total
  • controller_runtime_reconcile_time_seconds
  • controller_runtime_max_concurrent_reconciles
  • controller_runtime_active_workers

https://github.com/kubernetes-sigs/controller-runtime/blob/48ec3b71211f9fe1a313e34a9b44c39ca3adeec2/pkg/internal/controller/metrics/metrics.go#L25-L94

new metric name cannot duplicate existing metric, so metrics name might be startwith async_worker?

Why is this needed:
Useful for analyzing controller execution rates and queue backlog issues
@CharlesQQ CharlesQQ added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2024
@CharlesQQ CharlesQQ changed the title Add controller_runtime_reconcile_time_seconds metrics for resource detector controller Add resource_detector_reconcile_time_seconds metrics for resource detector controller Nov 8, 2024
@CharlesQQ CharlesQQ changed the title Add resource_detector_reconcile_time_seconds metrics for resource detector controller Add prometheus counter metrics for asyncWorker , which like metrics of controller-runtime repository Nov 8, 2024
@CharlesQQ CharlesQQ linked a pull request Nov 14, 2024 that will close this issue
Open
@RainbowMango
Copy link
Member

/assign @CharlesQQ
in favor of #5817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlesQQ CharlesQQ

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Overall Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(worker): add metrics for asyncworker CharlesQQ/karmada
2 participants
@RainbowMango @CharlesQQ