fix(cluster): remove raleted metrics label when cluster is deleted #5866
Conversation
Signed-off-by: chang.qiangqiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/S
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5866 +/- ##
==========================================
- Coverage 46.20% 46.19% -0.01%
==========================================
Files 663 663
Lines 54580 54594 +14
==========================================
+ Hits 25218 25221 +3
- Misses 27739 27750 +11
Partials 1623 1623
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| defer func() { | ||
| metrics.RemoveClusterStatus(cluster) | ||
| }() |
There was a problem hiding this comment.
What if the removeCluster raises an error? Do we still clean up the metrics?
There was a problem hiding this comment.
What if the removeCluster raises an error? Do we still clean up the metrics?
shouldn't clean up the metrics, I'll fix it!
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5843
Special notes for your reviewer:
Does this PR introduce a user-facing change?: