fix: ResourceBinding to be FullyApplied only when Work Status items are considered Healthy
#5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/M
…tems are considered `Healthy` Signed-off-by: Amir Alavi <[email protected]>
a7i
force-pushed
the
fix-rb-fullyapplied
branch
from
a345fe5
to
02953cf
Compare
a7i
commented
Nov 25, 2024
| @@ -283,6 +283,10 @@ func worksFullyApplied(aggregatedStatuses []workv1alpha2.AggregatedStatusItem, t | |||
| return false | |||
| } | |||
|
|
|||
| if aggregatedStatusItem.Health != workv1alpha2.ResourceHealthy { | |||
There was a problem hiding this comment.
If we have 2 member clusters, and it's healthy for one and not the other. Should be it considered fully applied? or not applied?
|
Per discussion in the issue, my use-case will be solved by querying both Health and FullyApplied==True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/king bug
What this PR does / why we need it:
Fixes ResouceBinding claiming to be fully applied before work status items are evaluated as Healthy
Which issue(s) this PR fixes:
Fixes #5867
Special notes for your reviewer:
Does this PR introduce a user-facing change?: