Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle absence of scheduler and controller-manager in a more convenient way #330

Closed
beorn7 opened this issue Jan 13, 2020 · 6 comments
Closed
Labels

Comments

@beorn7
Copy link
Contributor

beorn7 commented Jan 13, 2020

On managed K8s platforms, the metrics for scheduler and controller-manager are not necessarily accessible.

In that case, there is no good choice to set kubeSchedulerSelector and kubeControllerManagerSelector. For both, there are absence alerts (cf. #200 where the use case is to filter out the absence alert for the scheduler) and dashboards. The dashboards are useless, but they could just be ignored, while the absence alerts will always fire.

Currently, I guess, those have to be hidden in the local config, which is quite tedious. Would be nice if there was a more convenient way, e.g. setting the selectors to empty strings.

Or I am missing something here…

@brancz
Copy link
Member

brancz commented Jan 14, 2020

Filtering out the alert group should be easy enough no?

@beorn7
Copy link
Contributor Author

beorn7 commented Jan 14, 2020

In principle, yes. However, you have to filter out the alert group and you have to disable the dashboard, and the whole thing feels like low-level tweaking. However, I'd expect this issue to be very common (probably relevant for everybody using a managed K8s offering), and it would be really nice if there were an easy "flip this switch if you don't have a scheduler to scrape".

@brancz
Copy link
Member

brancz commented Jan 15, 2020

Sorry I should have been more precise. We could write a pretty easy jsonnet patch that removes the alert group and dashboard. Then anyone who uses a managed kube can just apply that patch. What do you think?

@beorn7
Copy link
Contributor Author

beorn7 commented Jan 15, 2020

Depends on the usability. As long as it boils down to "flip this switch", I think it's just an implementation detail if we use a jsonnet patch or a conditional.

@brancz
Copy link
Member

brancz commented Jan 16, 2020

Agreed, I tend to prefer patches when possible but you’re right.

Copy link

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants