Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intent of flaky test for test_rigid_rotation #195

Open
jlevin opened this issue Jan 5, 2023 · 0 comments
Open

Clarify intent of flaky test for test_rigid_rotation #195

jlevin opened this issue Jan 5, 2023 · 0 comments

Comments

@jlevin
Copy link
Contributor

jlevin commented Jan 5, 2023

See test_rigid_rotation_with_reflection() in test_rigid_transform.py

This test produces different answers on numpy 1.19.3 and higher on certain architectures. This is because there are duplicate singular values.

Since a reflection through the origin in 3-space is not a rotation at all, and there is no rotation matrix which can reflect through the origin, it's not clear what the correct result should be.

See also numpy/numpy#22945

Runtime information:

NumPy 1.19.3
Python 3.9.13 (main, May 27 2022, 22:45:39)
[GCC 9.4.0]

Note: This behavior is also occurring with numpy 1.24.1
Context for the issue:

The behavior is observed in CircleCI with the following info:
Docker with Python using cimg/python:3.9.13
Model name: Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz

Not reproducible on MacOS or Linux native.
Not reproducible on MacOS or Linux with same Docker image.
Not reproducible in Numpy 1.19.2.

@paulmelnikow paulmelnikow changed the title Update failing test so that the result of np.linalg.svd is unique Clarify flaky test for test_rigid_rotation Jan 12, 2023
@paulmelnikow paulmelnikow changed the title Clarify flaky test for test_rigid_rotation Clarify intent of flaky test for test_rigid_rotation Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant