Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loose all bookmarks when saving #13

Open
pabloalr opened this issue Nov 21, 2014 · 3 comments
Open

Loose all bookmarks when saving #13

pabloalr opened this issue Nov 21, 2014 · 3 comments
Assignees
Labels

Comments

@pabloalr
Copy link

It looks like tabs-to-spaces is clearing all bookmarks when I save any file.

@lee-dohm lee-dohm added the bug label Nov 22, 2014
@lee-dohm lee-dohm self-assigned this Nov 22, 2014
@lee-dohm
Copy link
Owner

I can confirm this on Atom v0.151.0-85fae83 on Mac OS X 10.10.1, though it isn't caused specifically by saving ... but by the act of tabifying or untabifying. You can prevent it from wiping out your bookmarks on every save by setting the onSave value to none.

I'm looking into what is actually causing this to happen.

@lee-dohm
Copy link
Owner

So it appears that this is caused by a TextBuffer.scan with replacements followed by a save operation. I replicated it just using the JavaScript console in Atom:

bookmarks

I'm going to file a bug on Atom Core and link it here.

@lee-dohm
Copy link
Owner

It actually doesn't have anything to do with the save operation, but it has to do with some sort of interaction with the decorations API that bookmarks uses and the TextBuffer.scan method when used to replace whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants