Issue with download all button, Zip downloads appear to be broken every so often

[ZoesDev]

Describe the bug
There seems to be a problem with the download all button. and doesnt appear to matter if the model has sub folders or not. as I was able to replicate it with a model with multiple files and multiple folders. the sometimes it appears it isnt waiting for the zip to be completed before it sends the download to the browser to download. I have attached a screenshot of what i mean, the 46.1MB zip is broken and the 283.1MB zip is working and able to extract.

this seems to be a sporadic issues but I am able to replicate it fairly constantly in at atleast 1 out of 4-6 downloads I create.

To Reproduce
Steps to reproduce the behavior:

1. Go to any model
2. Click on download all or download STL files as I have been able to replicated it with that too.
3. click on the zip and get an error sometimes if the zip is not the right size

Expected behavior
That the zip files would wait till its fully ready to go and then send to browser so that the zip files do not arrive broken. Probably future feature to have a status bar with this so we can see when it will be ready.

Screenshots

Desktop (please complete the following information):

• OS: MacOS 15
• Browser firefox
• Version 132

Additional context
Not sure if this matters but my models are stored on a san with 100gbps connection to the server that runs the proxmox server that runs the vm for the containers I have on the server.

[Floppy]

@ZoesDev do you get both good and bad downloads from the same model? So it would seem to be very much related to the generation of the download, not the contents as such?

[ZoesDev]

@Floppy that is exactly it. I can go to any model I have and if I click the download button I can get both zips you see. With time between each click.

I got to thinking maybe a smaller size model won’t have issues so will try that today and report back.

[Floppy]

OK thanks. I've tested the downloads on lots of models, but I probably haven't tried to open all of them. I'll test here too.

[Floppy]

I've had a sudden realisation about this - you might be downloading a half-built archive. I just managed to do this by clicking "download", thinking nothing had happened (this is a known problem with lack of feedback), then clicking again. It immediately gave me the half-completed download archive from the first click.

Does that sound like what might have happened to you? I've just realised how easily it can happen...

[ZoesDev]

Looking at it. I do think that is what is going on. I just tested it again, for my ca3d 2b model, the first zip was only 361mb the second one was 612mb. I also just tried it with another file and it was a 2.7gb zip and took quite a while to get and noticed there is no feedback in the log as the button is pushed ether which is interesting to me as I would expect a start line that it is starting at least.

I do think it is the lack of feed back and the fact I move quickly so I double click a lot more then I should. I did test it and if I actively make sure I click only once and wait for it to do anything it does grab the full zip it looks like.

Is there a way to make it so that button can only be clicked 1 time till the download for it is complete so this doesnt happen?

[Floppy]

Yep - that's the right solution. I'll get on it. Thanks!