Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript compilation errors in HeadingIndicator and geoUtils v10.0.0-alpha.22 #476

Closed
madmeatballs opened this issue Oct 24, 2024 · 5 comments
Closed

Typescript compilation errors in HeadingIndicator and geoUtils v10.0.0-alpha.22 #476

madmeatballs opened this issue Oct 24, 2024 · 5 comments
Labels
bug Something isn't working
Milestone
10.0.0

Comments

@madmeatballs
Copy link

madmeatballs commented Oct 24, 2024 •
edited
Loading

Steps to Trigger Behavior

  1. install @maplibre/maplibre-react-native 10.0.0-alpha.22 to your project
  2. npx tsc --noEmit

Expected Behavior

no ts issues

Actual Behavior

ts errors in javascript/components/HeadingIndicator.tsx:4:25

Screenshots (if applicable)

Screenshot 2024-10-24 at 6 05 03 PM

Version(s) affected

  • maplibre-react-native Version 10.0.0-alpha.22
@madmeatballs
Copy link
Author

#422

seems like this issue has come back. Now just the heading.png

@madmeatballs
Copy link
Author

madmeatballs commented Oct 24, 2024 •
edited
Loading

@tyrauber the fix seems to be the same fix as before in #423 by @caspg

@KiwiKilian
Copy link
Collaborator

KiwiKilian commented Oct 24, 2024 •
edited
Loading

Sorry, I might have reintroduced the problem with 77701aa. But there should be a better solution than @ts-ignore. Will have a look tomorrow. What does your tsconfig.json look like?

@KiwiKilian
Copy link
Collaborator

Ok, I can reproduce the problems about the *.png types, but are you sure there is also a problem again around the geoUtils?

KiwiKilian added a commit to trafficon/maplibre-react-native that referenced this issue Oct 25, 2024
@KiwiKilian
fix: keep @ts-ignore for headingIcon in library maplibre#476
4b85cba
tyrauber pushed a commit that referenced this issue Oct 26, 2024
@KiwiKilian
fix: keep @ts-ignore for headingIcon in library #476 (#477)
ef62454 
* fix: keep @ts-ignore for headingIcon in library #476
* chore: update CHANGELOG
@KiwiKilian
Copy link
Collaborator

This was fixed and will be further improved through fixing #482.

@KiwiKilian KiwiKilian added the bug Something isn't working label Nov 15, 2024
@KiwiKilian KiwiKilian added this to the 10.0.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@KiwiKilian @madmeatballs