Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N3980: a more flexible way of hashing #27

Open
amallia opened this issue Jun 28, 2017 · 3 comments
Open

N3980: a more flexible way of hashing #27

amallia opened this issue Jun 28, 2017 · 3 comments

Comments

@amallia
Copy link
Contributor

amallia commented Jun 28, 2017

The next version should have a more flexible way of hashing according to N3980, which @mavam started in topic/n3980.

This issue will help us discussing about it.

@mavam
Copy link
Owner

mavam commented Jun 28, 2017

Thanks for opening this one up. I've actually completed the heavy lifting in a separate project:

https://github.com/vast-io/vast/tree/master/libvast/vast/concept/hashable

What remains is adjusting the hasher API.

@amallia
Copy link
Contributor Author

amallia commented Jun 28, 2017

Oh, this is cool!
This will allow to have any type hashable and so able to add to a BF.
From my understand currently only arithmetic types (and arrays or vector of them) and string are supported.

@mavam
Copy link
Owner

mavam commented Jun 28, 2017

This will allow to have any type hashable and so able to add to a BF.

Exactly! It also decouples the hash algorithm implementation, so that we can use a variety of different algorithms in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants