-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: [Number Series Copilot] Bug fixes #2106
Labels
Approved
The issue is approved
Bug
Something isn't working
Integration
GitHub request for Integration area
Comments
DmitryKatson
added a commit
to DmitryKatson/BCApps
that referenced
this issue
Sep 27, 2024
…ation Summary: This commit resolves three bugs in the Number Series generation process. It improves intent mapping for the "Generate" command, corrects field checks for existing Number Series, and refines validation logic to allow optional fields to be blank. These fixes enhance the accuracy and reliability of Number Series generation. Fixes microsoft#2106
JesperSchulz
pushed a commit
that referenced
this issue
Oct 23, 2024
…alidation (#2111) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This PR addresses three critical bugs in the Number Series Copilot: 1. **Bug 1: Incorrect Intent Mapping for "Generate" Command** - The system was misinterpreting the "generate" command, often preparing Number Series for the next period instead of creating a new one. The fix involves updating the tools definition and prompt to clarify the distinction between creating new Number Series and generating Number Series for the next period. 2. **Bug 2: Incorrect Field Check for Existing Number Series** - The system was incorrectly performing checks on all fields for existing Number Series. The fix modifies the behavior to exclude pre-existing Number Series from the field validation checks, ensuring that only mandatory fields are validated for AI generated series. 3. **Bug 3: Blank Fields Causing Validation Errors** - The system was generating Number Series without values for optional fields, causing validation errors. The fix refines the validation logic so that only mandatory fields are checked, allowing optional fields to remain blank if necessary. **Steps to Implement:** 1. Refactor the LLM prompt and tools definition to improve the understanding of user intent between creating and preparing Number Series for different periods. 2. Update the logic to exclude field checks for existing Number Series and restrict checks to mandatory fields. **Acceptance Criteria:** - Users can create Number Series without mistakenly triggering next-period Number Series generation when using the word "generate." - Existing Number Series are excluded from unnecessary checks, and only mandatory fields are validated for new series. These fixes aim to enhance the accuracy and reliability of the Number Series Copilot, ensuring it correctly interprets user commands and validates the necessary fields. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #2106 Fixes [AB#550892](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/550892), [AB#544073](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/544073)
JesperSchulz
pushed a commit
that referenced
this issue
Oct 23, 2024
…alidation (#2111) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This PR addresses three critical bugs in the Number Series Copilot: 1. **Bug 1: Incorrect Intent Mapping for "Generate" Command** - The system was misinterpreting the "generate" command, often preparing Number Series for the next period instead of creating a new one. The fix involves updating the tools definition and prompt to clarify the distinction between creating new Number Series and generating Number Series for the next period. 2. **Bug 2: Incorrect Field Check for Existing Number Series** - The system was incorrectly performing checks on all fields for existing Number Series. The fix modifies the behavior to exclude pre-existing Number Series from the field validation checks, ensuring that only mandatory fields are validated for AI generated series. 3. **Bug 3: Blank Fields Causing Validation Errors** - The system was generating Number Series without values for optional fields, causing validation errors. The fix refines the validation logic so that only mandatory fields are checked, allowing optional fields to remain blank if necessary. **Steps to Implement:** 1. Refactor the LLM prompt and tools definition to improve the understanding of user intent between creating and preparing Number Series for different periods. 2. Update the logic to exclude field checks for existing Number Series and restrict checks to mandatory fields. **Acceptance Criteria:** - Users can create Number Series without mistakenly triggering next-period Number Series generation when using the word "generate." - Existing Number Series are excluded from unnecessary checks, and only mandatory fields are validated for new series. These fixes aim to enhance the accuracy and reliability of the Number Series Copilot, ensuring it correctly interprets user commands and validates the necessary fields. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #2106 Fixes [AB#550892](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/550892), [AB#544073](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/544073)
Also backporting to 25.x. Reopening. |
JesperSchulz
added a commit
that referenced
this issue
Oct 23, 2024
…ield V… (#2251) …alidation (#2111) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This PR addresses three critical bugs in the Number Series Copilot: 1. **Bug 1: Incorrect Intent Mapping for "Generate" Command** - The system was misinterpreting the "generate" command, often preparing Number Series for the next period instead of creating a new one. The fix involves updating the tools definition and prompt to clarify the distinction between creating new Number Series and generating Number Series for the next period. 2. **Bug 2: Incorrect Field Check for Existing Number Series** - The system was incorrectly performing checks on all fields for existing Number Series. The fix modifies the behavior to exclude pre-existing Number Series from the field validation checks, ensuring that only mandatory fields are validated for AI generated series. 3. **Bug 3: Blank Fields Causing Validation Errors** - The system was generating Number Series without values for optional fields, causing validation errors. The fix refines the validation logic so that only mandatory fields are checked, allowing optional fields to remain blank if necessary. **Steps to Implement:** 1. Refactor the LLM prompt and tools definition to improve the understanding of user intent between creating and preparing Number Series for different periods. 2. Update the logic to exclude field checks for existing Number Series and restrict checks to mandatory fields. **Acceptance Criteria:** - Users can create Number Series without mistakenly triggering next-period Number Series generation when using the word "generate." - Existing Number Series are excluded from unnecessary checks, and only mandatory fields are validated for new series. These fixes aim to enhance the accuracy and reliability of the Number Series Copilot, ensuring it correctly interprets user commands and validates the necessary fields. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #2106 Fixes [AB#555649](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/555649) Co-authored-by: Dmitry Katson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
The issue is approved
Bug
Something isn't working
Integration
GitHub request for Integration area
Describe the issue
Bugs
Bug 1: Incorrect Intent Mapping for "Generate" Command
Bug 2: Incorrect Field Check for Existing Number Series
Bug 3: Blank Fields Causing Validation Errors
Expected behavior
Steps to Implement:
Steps to reproduce
Acceptance Criteria:
Additional context
No response
I will provide a fix for a bug
The text was updated successfully, but these errors were encountered: