Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Connector Package Validator Script: Plugin Enabled Switch not working #3671

Open
stefansidler opened this issue Sep 30, 2024 · 1 comment

Comments

@stefansidler
Copy link

stefansidler commented Sep 30, 2024

The Connector Package Validator Script does not correctly respect the "pluginEnabled" parameter.

Therefore the validation always fails for Connector which are not using the AI Plugin.

The Bugs are on line 388:
if ($pluginEnabled) {

and line 485:
elseif ($pluginEnabled -and (-not $isPluginSolutionPresent)) {

The variable names should be $isPluginEnabled on both lines.
The parameter $pluginEnabled is a string and is converted into a boolean $isPluginEnabled on lines 217-223.

@kola-tm
Copy link

kola-tm commented Oct 18, 2024

Hey bud, i raised a PR to fix this a while ago here, but was asked to close it. They have finally added a PR here. The fix could have been a lot simpler but lets see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants