Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did you forget to add an app icon to the WinUI 3 Gallery main application? #1600

Open
Gaoyifei1011 opened this issue Aug 6, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Gaoyifei1011
Copy link

Which version of the app?

WinUI 3 Gallery

Description

Did you forget to add an app icon to the WinUI 3 Gallery main application?

Screenshots

{A7295769-EAFD-4DFF-BF89-AA699168FE38}

Windows version

Windows 11 24H2 (26052)

Additional context

None

@Gaoyifei1011 Gaoyifei1011 added bug Something isn't working needs-triage labels Aug 6, 2024
@MGGSK
Copy link
Contributor

MGGSK commented Aug 9, 2024

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

@Gaoyifei1011
Copy link
Author

Gaoyifei1011 commented Aug 13, 2024

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

But I don't think so. First, Winui 3 is a desktop application, and UWP is a packaged application. In the task Manager, the Winui 3 desktop program shows the icon of the application instead of the packaged application icon, which does not quickly locate the application by the icon in the Task Manager. Second, Microsoft's other official packaging applications, Dev home, drawing and other software, they have set up application ICONS, so I think Winui 3 gallery should add application ICONS
然而我却不是这样认为。首先,Winui 3 是一个桌面程序,UWP 是一个打包后的应用。在任务管理器中,Winui 3 桌面程序显示的是应用程序的图标,而不是打包应用程序的图标,这并不能在任务管理器中通过图标快速定位应用程序。其次,微软官方的其他打包应用,Dev home,画图等等其他软件,他们都设置了应用程序图标,所以我认为应该给 Winui 3 gallery 添加上应用程序图标
{92920F28-79A1-421F-AE98-5DFB73BE5CC2}

@MGGSK
Copy link
Contributor

MGGSK commented Aug 13, 2024

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

But I don't think so. First, Winui 3 is a desktop application, and UWP is a packaged application. In the task Manager, the Winui 3 desktop program shows the icon of the application instead of the packaged application icon, which does not quickly locate the application by the icon in the Task Manager. Second, Microsoft's other official packaging applications, Dev home, drawing and other software, they have set up application ICONS, so I think Winui 3 gallery should add application ICONS 然而我却不是这样认为。首先,Winui 3 是一个桌面程序,UWP 是一个打包后的应用。在任务管理器中,Winui 3 桌面程序显示的是应用程序的图标,而不是打包应用程序的图标,这并不能在任务管理器中通过图标快速定位应用程序。其次,微软官方的其他打包应用,Dev home,画图等等其他软件,他们都设置了应用程序图标,所以我认为应该给 Winui 3 gallery 添加上应用程序图标 {92920F28-79A1-421F-AE98-5DFB73BE5CC2}

First: WinUI 3 apps are also packaged
Second: What I meant by "useless" was applying it as the app exe file icon but it is useful in the taskbar because WinUI is weird (with packaged taskbar icons).
Third: I think it would be good if an exe icon was added because using an png file as a icon in the taskbar doesn't look good (no transparency). Edit: using the default exe icon look extremely wrong. Edit 2: The taskbar icon was already fixed but I still made a pr that changes the exe icon.

@MGGSK MGGSK mentioned this issue Aug 13, 2024
3 tasks
karkarl pushed a commit that referenced this issue Aug 27, 2024
Added a icon to the apps exe file.

## Description
Set the exe icon in the project properties to
"Assets\Tiles\GalleryIcon.ico"

## Motivation and Context
Don't know why the exe doesn't have an icon.
Fixed this issue: #1600

## How Has This Been Tested?
No testing needed.

## Screenshots (if appropriate):

![image](https://github.com/user-attachments/assets/3edf60e8-b517-4448-851a-a6df71945a9d)

## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
@HEIC-to-JPEG-Dev
Copy link

The icon should be added - Windows taskbar needs it to display properly
Image

@MGGSK
Copy link
Contributor

MGGSK commented Oct 16, 2024

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. #1604

@HEIC-to-JPEG-Dev
Copy link

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. #1604

It's not in the current release either

@MGGSK
Copy link
Contributor

MGGSK commented Oct 16, 2024

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. #1604

It's not in the current release either

It will be in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants