Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar chrome buttons wrong color "invisible" #1605

Open
HEIC-to-JPEG-Dev opened this issue Aug 15, 2024 · 8 comments
Open

Titlebar chrome buttons wrong color "invisible" #1605

HEIC-to-JPEG-Dev opened this issue Aug 15, 2024 · 8 comments
Labels
bug Something isn't working needs-author-feedback

Comments

@HEIC-to-JPEG-Dev
Copy link

Which version of the app?

WinUI 3 Gallery

Description

The titlebar chrome buttons (minimize, maximize, close) are not visible. Screenshot below.

I think this is because the Windows 11 setting "Show accent colour on title bars and window borders" is checked. Turning this off solves the issue - but I (and I assume lots of people) have it switched on.

Screenshots

image

Windows version

Windows 11 23H2 (22631)

Additional context

As a developer I know this issue and it has to be manually managed in code as the AppWindow theme system is broken. Using th enew Titlebar control in SDK 1.6 fixes the issue.

@HEIC-to-JPEG-Dev HEIC-to-JPEG-Dev added bug Something isn't working needs-triage labels Aug 15, 2024
@karkarl
Copy link
Collaborator

karkarl commented Aug 15, 2024

I am unable to repro, can you provide more detailed repro steps?

I wonder if it's from WinUI-Gallery setting AppWindow TitleBar's caption button colours as a workaround here:

public static Windows.UI.Color ApplySystemThemeToCaptionButtons(Window window)

@HEIC-to-JPEG-Dev
Copy link
Author

If you close the app, and then set this in Windows Settings, on Windows 11, you should be able to reproduce the issue
image

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Aug 31, 2024

Ideally, a window shouldn't have to mess with code like this and the solution is to be as "native" as possible.

it has to be manually managed in code as the AppWindow theme system is broken

Seen this so many times for so long, I wonder if Microsoft will ever fix it...

Using th enew Titlebar control in SDK 1.6 fixes the issue.

🥳

@HEIC-to-JPEG-Dev
Copy link
Author

The titlebar control is not in 1.6, it was pulled :(

@Jay-o-Way
Copy link
Contributor

The titlebar control is not in 1.6, it was pulled :(

OMG! What's the source for this info?

@HEIC-to-JPEG-Dev
Copy link
Author

They announced it on the developer call. No ETA. Had to pull it from my app and revert back to older code

@karkarl
Copy link
Collaborator

karkarl commented Sep 3, 2024

The titlebar control is not in 1.6, it was pulled :(

OMG! What's the source for this info?

I can answer this question - it is true that Titlebar will not be shipping in 1.6, however, we are still committed to shipping the control eventually. It's looks "pulled" since experimental APIs cannot be shipped with a stable release.

Hopefully I can provide more info to this in a couple of weeks :)

@HEIC-to-JPEG-Dev
Copy link
Author

Are we saying this won't be fixed until SDK 1.7 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-author-feedback
Projects
None yet
Development

No branches or pull requests

3 participants