Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Corsair.iCUE.5 version 5.21.107 #193586

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New version: Corsair.iCUE.5 version 5.21.107 #193586

wants to merge 4 commits into from
+6 −4

Conversation

VlaDexa
Copy link
Contributor

@VlaDexa VlaDexa commented Nov 25, 2024 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@VlaDexa
Copy link
Contributor Author

VlaDexa commented Nov 25, 2024

Closes #193460

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 25, 2024
@Dragon1573
Copy link
Contributor

Closes #193460

Originally posted in #193586 (comment)

Hi @VlaDexa, 👋🏼

Tip

This "close command" is only valid inside the very first comment of the pull request.

Cloud you please edit your very first comment and place this "close command" there? 🙏🏼

@Trenly
Copy link
Contributor

Trenly commented Nov 25, 2024 •
edited
Loading

@VlaDexa - When I test this on my VM, the installer only downloads and installs the Visual C++ 2015-2022 Redistributable, and never installs iCUE 5. Are different installer switches needed for this version?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 25, 2024
@VlaDexa
Copy link
Contributor Author

VlaDexa commented Nov 25, 2024 •
edited
Loading

@Trenly I don't think so? I've re-run the winget install command once more (after uninstalling iCUE first) on my machine, and it still works. Maybe iCUE has an issue with VMs?

@Dragon1573 Sure, done

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 25, 2024
@Dragon1573
Copy link
Contributor

@Trenly I don't think so? I've re-run the winget install command once more (after uninstalling iCUE first) on my machine, and it still works. Maybe iCUE has an issue with VMs?

It might be? Is Windows Sandbox feature enabled on your device? Could you please manually validate the package with Tools/SandboxTest.ps1?

@Dragon1573
Copy link
Contributor

@VlaDexa @Trenly, for some reason I'm behind a proxy provided by Clash for Windows version v0.20.29, serve as my.device.local:57890 with protocol http:// and socks://.

I try to launch a Windows Sandbox instance for manual validation, but it seems stuck when I'm performing an interactive installation ...

Console outputs 
21:12:04 D:\...\winget-pkgs  [pr/VlaDexa/193586 +0 ~1 -0 !] 0ms pwsh> .\Tools\SandboxTest.ps1 .\manifests\c\Corsair\iCUE\5\5.21.107\ -WinGetOptions '--interactive'
--> Validating Manifest
清单具有以下未验证的依赖项;确保它们有效：
- 程序包
Microsoft.VCRedist.2015+.x64 [>= 14.38.33130.0]
清单验证成功。
--> Checking Dependencies
--> Starting Windows Sandbox, and:
    - Mounting the following directories:
      - C:\Users\Dragon1573\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\SandboxTest as read-and-write
      - D:\Repository\winget-pkgs as read-and-write
    - Installing WinGet
    - Configuring Winget
      - Installing the Manifest 5.21.107
      - Refreshing environment variables
      - Comparing ARP Entries

--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 5.21.107

Found Corsair iCUE5 Software [Corsair.iCUE.5] Version 5.21.107
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.VCRedist.2015+.x64 [>= 14.38.33130.0]
(1/1) Found Microsoft Visual C++ 2015-2022 Redistributable (x64) [Microsoft.VCRedist.2015+.x64] Version 14.42.34433.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/c7dac50a-e3e8-40f6-bbb2-9cc4e3dfcabe/1821577409C35B2B9505AC833E246376CC68A8262972100444010B57226F0940/VC_redist.x64.exe
  ██████████████████████████████  24.4 MB / 24.4 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://www3.corsair.com/software/CUE_V5/public/modules/windows/installer/Install%20iCUE.exe
  ██████████████████████████████  3.22 MB / 3.22 MB
Successfully verified installer hash
Starting package install...
   |

image

@Dragon1573
Copy link
Contributor

If I launch Tools/SandboxTest.ps1 without -WingetOptions, the winget.exe install process will soon finish without iCUE 5 written to ARP Entries.

Then try to launch a new installation process via $env:TEMP folder interactively, it will immediately failed and complaining that "there's another process already running".

It seems that there's something weird blocking the installation in Windows Sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: Corsair.iCUE.5
5 participants
@VlaDexa @wingetbot @Dragon1573 @Trenly @stephengillie