repl crash when loading a module containing an undefined $identifier

[justinnoah]

The code, example.mt:

def example():
  def x := `$blah`

The Result:

$ monte repl

Taking initial turn in script...
TRACE: time 1549409824.753021 vat pa
 ~ "Loader args: [\"run\", \"tools/repl\"]"
TRACE: time 1549409824.753143 vat pa
 ~ "Loading tools/repl"
▲> repl.load(".", "example")
TRACE: time 1549409903.158639 vat pa                                                                                                                                                          
 ~ "Reading file: ./example.mt"                                                                                                                                                               
Result: <promise>                                                                                                                                                                             
▲> TRACE: time 1549409903.159975 vat pa                                                                                                                                                       
 ~ "Parsing Monte code: ./example.mt"
Name blah has no scope
RPython traceback:
  File "implement.c", line 58, in entryPoint
  File "implement.c", line 4136, in runTyphon
  File "implement.c", line 5923, in runUntilDone
  File "typhon_vats.c", line 449, in Vat_takeSomeTurns
  File "typhon_vats.c", line 1544, in Vat_takeTurn
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "implement.c", line 33132, in WhenResolvedReactor_recvNamed
  File "typhon_objects.c", line 42336, in WhenResolvedReactor_run
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "typhon_nano.c", line 9876, in InterpObject_runMethod
  File "typhon_nano.c", line 19124, in Evaluator_visitSeqExpr
  File "typhon_nano.c", line 14267, in Evaluator_visitCallExpr
  File "typhon_nano.c", line 14700, in Evaluator_visitDefExpr
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "typhon_nano.c", line 9876, in InterpObject_runMethod
  File "typhon_nano.c", line 19124, in Evaluator_visitSeqExpr
  File "typhon_nano.c", line 14700, in Evaluator_visitDefExpr
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "typhon_nano.c", line 9876, in InterpObject_runMethod
  File "typhon_nano.c", line 19124, in Evaluator_visitSeqExpr
  File "typhon_nano.c", line 14700, in Evaluator_visitDefExpr
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "typhon_nano.c", line 9876, in InterpObject_runMethod
  File "typhon_nano.c", line 19124, in Evaluator_visitSeqExpr
  File "typhon_nano.c", line 14101, in Evaluator_visitCallExpr
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "typhon_nano.c", line 9876, in InterpObject_runMethod
  File "typhon_nano.c", line 19124, in Evaluator_visitSeqExpr
  File "typhon_objects.c", line 5665, in Object_callAtom
  File "implement_4.c", line 56719, in AstEval_recvNamed
  File "typhon_scopes.c", line 12442, in AstEval_evalToPair
  File "typhon_nano_1.c", line 37235, in evalToPair
  File "typhon_nano.c", line 233, in evalMonte
  File "typhon_nano.c", line 5489, in mainPipeline
  File "implement_2.c", line 41827, in Pass_visitExpr_14
  File "typhon_nano_1.c", line 11433, in ScopeFrame_computeFrameTable
Fatal RPython error: CompilerFailed
rlwrap: warning: mt-typhon crashed, killed by SIGABRT.
rlwrap itself has not crashed, but for transparency,
it will now kill itself (without dumping core) with the same signal


warnings can be silenced by the --no-warnings (-n) option
/nix/store/71fxsl7js18g8m4s3vwsii47dlxp1wlr-monte/bin/monte: line 61:  6151 Aborted                 $RLWRAP /nix/store/zy9sm85nh1yl532fagfw0ijmhd0s8qjc-typhon-vm/mt-typhon -l /nix/store/nra74gpdklqvs70nimzvx22ajw2zniiy-mast /nix/store/nra74gpdklqvs70nimzvx22ajw2zniiy-mast/loader run tools/repl

Expected Result:
Syntax Error with ^---- pointing out the incorrect $identifier (or similar)

[justinnoah]

Typhon @ ee2c92d

[MostAwesomeDude]

Nice find. Looks like this is yet another instance of Typhon doing the wrong thing when loading a module with some undefined names.