Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example config should have idpCert instead of cert option starting from 5.0.0 #940

Open
srd90 opened this issue Nov 18, 2024 · 0 comments
Open
Labels

Comments

@srd90
Copy link

srd90 commented Nov 18, 2024

@node-saml/node-saml 5.0.0 refactored cert to idpCert:

Change has been reflected to @node-saml/passport-saml ADFS related example:

idpCert: 'MIICizCCAfQCCQCY8tKaMc0BMjANBgkqh ... W==',

but it was not reflected to "general" example:

cert: "fake cert", // cert must be provided

Links to codebase point to 5.0.0 version.

Aforementioned minor documentation issue might explain this comment at another issue: node-saml/node-saml#379 (comment)

...
You pointed me to the use of idpcert instead of cert for my MSEntra IDP. FYI: Our users/companies may not (probably won't) all use MSEntra.
...

Comment gave an impression (when combined with other info) that user had interpreted documentation and comments so that MS related IdPs would use idpCert and others cert. Let the record show that node-saml/node-saml#379 should have been discussion and at passport-saml project.

Environment

  • passport-saml version: 5.0.0
@srd90 srd90 added the bug label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant