Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How to build #12

Open
hyunseok-yang opened this issue Apr 17, 2023 · 9 comments
Open

[Question] How to build #12

hyunseok-yang opened this issue Apr 17, 2023 · 9 comments

Comments

@hyunseok-yang
Copy link

Hello, Grey.

I'm trying to build a mapf code. But It's hard to build or run because this is my first experience of Rust code :)
Could you let me know how to build a code?

@mxgrey
Copy link
Contributor

mxgrey commented Apr 17, 2023

We definitely need to add some instructions/links to the README for how to get started with Rust. I'll keep this issue open until we've done that, but in the meantime, you can find instructions on getting started with Rust here: https://www.rust-lang.org/learn/get-started

Instructions for installing Rust can be found here: https://www.rust-lang.org/tools/install

After that you can run $ cargo build to build the library.

There's an example you can run using $ cargo run --release --example grid_planner although some of the controls for the example aren't finished yet on the main branch.

@hyunseok-yang
Copy link
Author

hyunseok-yang commented Apr 18, 2023

hi,
Thanks for your reply :)

I tried to build with stable version of toolchain. Then I got this message.

image

After I changed to nightly version of toolchain. Then I got this message.

image

@arjo129
Copy link
Member

arjo129 commented Apr 18, 2023 via email

@hyunseok-yang
Copy link
Author

Have you tried building with the nightly toolchain?

On Tue, Apr 18, 2023 at 11:24 AM Hyunseok @.> wrote: I tried to build with stable version of toolchain. Then I got this message. [image: image] https://user-images.githubusercontent.com/21001946/232662805-56c1ca60-00e1-4a6d-a705-ffddcd8b4789.png After I changed to nightly version of toolchain. Then I got this message. [image: image] https://user-images.githubusercontent.com/21001946/232662995-c1f48899-19f5-4e6e-8838-a1632039e337.png — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEEMQGMP5Q6GM4GL46LX63XBYCPRANCNFSM6AAAAAAXAUIR3E . You are receiving this because you are subscribed to this thread.Message ID: @.>

Hi!

Yes, I tiried with nightly toolchain then I got the error message like above. I mean second screenshot.

@arjo129
Copy link
Member

arjo129 commented Apr 18, 2023 via email

@mxgrey
Copy link
Contributor

mxgrey commented Apr 18, 2023

I believe I understand what's happening.

A recent update to Rust has changed the naming of the feature gates for an unstable feature that we're using. @arjo129 and I haven't noticed this because we installed our versions of Rust 3+ months ago and don't have the latest version of nightly. @hyunseok-yang just installed a fresh version of Rust, so he's experiencing this error.

I just ran rustup update and now I see the same error as @hyunseok-yang . I'll make a quick PR to fix this.

@mxgrey
Copy link
Contributor

mxgrey commented Apr 18, 2023

This PR should fix the issue: #13

This is unfortunately one of the risks of using unstable language features, but I think the payoff is worth it. This feature in particular gives us a huge amount of flexibility when implementing custom planning domains without hurting performance.

We should copy what we've done for the site editor and run nightly CI to check if an upstream update to Rust has broken the build.

@hyunseok-yang
Copy link
Author

This PR should fix the issue: #13

This is unfortunately one of the risks of using unstable language features, but I think the payoff is worth it. This feature in particular gives us a huge amount of flexibility when implementing custom planning domains without hurting performance.

We should copy what we've done for the site editor and run nightly CI to check if an upstream update to Rust has broken the build.

Oh, not it worked. The build was fine :)

@hyunseok-yang
Copy link
Author

example also works well :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants