Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools-v2]:better build tools-v2 #2602

Open
Cyber-SiKu opened this issue Jun 30, 2023 · 5 comments
Open

[tools-v2]:better build tools-v2 #2602

Cyber-SiKu opened this issue Jun 30, 2023 · 5 comments
Labels
enhancement improve feature

Comments

@Cyber-SiKu
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

Currently compiling tools-v2 is in the main process of compiling and cannot be skipped. Even the same as below will compile. Please optimize this.

make build stor=fs release=1 only=curvefs/src/metaserver/*

Describe the solution you'd like (描述你期望的解决方法)

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Cyber-SiKu Cyber-SiKu added the enhancement improve feature label Jun 30, 2023
@zztaki
Copy link
Contributor

zztaki commented Dec 22, 2023

Hello, I have located the location that needs to be modified. I would like to discuss with you when we need to compile tools-v2 and when not. :)

@zztaki
Copy link
Contributor

zztaki commented Dec 22, 2023

A simple way is if we specify only (alias g_target) then we don't compile it.

@zztaki
Copy link
Contributor

zztaki commented Dec 22, 2023

Or we add add an independent parameter (eg. skiptools) to specify whether to skip the compilation of tools-v2

@montaguelhz
Copy link
Contributor

Adding new parameters seems unnecessary, welcome to do it. @zztaki

@zztaki
Copy link
Contributor

zztaki commented Jan 5, 2024

Adding new parameters seems unnecessary, welcome to do it. @zztaki

Thank you for your help :) @montaguelhz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature
Projects
None yet
Development

No branches or pull requests

3 participants