Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gsoc22] MeshGraphViewer integration feedback #142

Open
mwarning opened this issue Jul 4, 2022 · 2 comments
Open

[gsoc22] MeshGraphViewer integration feedback #142

mwarning opened this issue Jul 4, 2022 · 2 comments
Labels

Comments

@mwarning
Copy link

mwarning commented Jul 4, 2022

Hi,

just a unrefined collection of issue I run into when using netjsongraph.js for MeshGraphViewer.
Current code: https://github.com/mwarning/MeshGraphViewer/tree/netjson

  • how to disable/hide the "NetJSONGraph" title that is printed on top?
  • allow new NetJSONGraph(netjson_options); without passing a path to a json file. For the Meshviewer, the data is available in a variable, it does not come as a file.
  • allow a uni colored background for the map. This is a good idea for when no Internet is available or for making screenshots without a mpa background
  • Lot's of errors like Node 172.16.146.1 position is undefined! while that is expected. Not all nodes have location information. Can we remove it from the code or make it a warning and then be able to disable it?
  • Can't change el again! netjsongraph.min.js, no idea why this is comming
  • LinkStyle in https://github.com/openwisp/netjsongraph.js/blob/gsoc22/examples/netjsongraph-elementsLegend.html#L107 gives me hard to locate problems when the json is modified with a missing or unknown link type. => let's a default
@mwarning
Copy link
Author

mwarning commented Jul 4, 2022

@totallynotvaishnav @nemesisdesign fyi, I need a place to unload my questions and problems as I use the code :-)

@mwarning
Copy link
Author

All items listed so far have been resolved!

To get on par of with the features with the current MeshGraphViewer based on the old code base, these two features would be needed/hooked into netjsonmap.js:

What would be needed here is an example that shows how to solves this with hooks/callbacks. I do not think this is a feature that should be part of netjsongraph.js itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant