Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check code coverage reporting #2060

Open
audiodude opened this issue Jul 7, 2024 · 3 comments
Open

Double check code coverage reporting #2060

audiodude opened this issue Jul 7, 2024 · 3 comments

Comments

@audiodude
Copy link
Member

In #2055 I got a notification that the line I changed was missing coverage:

image

However when I added a log statement here I could see that the code was being executed by this test

Perhaps e2e tests are not being counted for coverage?

@audiodude
Copy link
Member Author

Actually that doesn't make sense, because it is a unit test.

@kelson42
Copy link
Collaborator

kelson42 commented Jul 7, 2024

unit test code should be excluded of code coverage. We fix that in the config yml file for codecov.

@kelson42 kelson42 added the bug label Jul 7, 2024
@audiodude
Copy link
Member Author

What I meant was, the test I linked to is a unit test, so my hypothesis that "e2e tests are not generating coverage" is definitely wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants