Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag name convention #2

Open
dkastl opened this issue Oct 18, 2018 · 10 comments
Open

Tag name convention #2

dkastl opened this issue Oct 18, 2018 · 10 comments

Comments

@dkastl
Copy link
Member

dkastl commented Oct 18, 2018

@cayetanobv , I saw that you were trying a few different ways to name the tags.

What if we would follow the way Debian packages are named?
For example: https://packages.debian.org/sid/hppa/postgresql-10-pgrouting/download

The package name starts with postgresql-{version} followed by -pgrouting_version.

@cayetanobv
Copy link
Member

cayetanobv commented Oct 18, 2018

Hi @dkastl , I'm not totally convinced of current tag naming system but I couldn't find another that "sounds" better :)
We can discuss how to improve (and of course make a change in the current system) but we shoud take in consideration that Docker image naming system is the following:

{organization_name}/{repository_name}:{tag}

Example with current naming system:

pgrouting/docker-pgrouting:pg_10_2.6.1

Example with debian based naming system:

pgrouting/docker-pgrouting:postgresql-10-pgrouting-2.6.1

It is a little bit long but it sounds good and maybe it is more clear for people.

On the other hand I make a mistake with Docker repository name. It must be "pgrouting" and not "docker-pgrouting" (which is the github repository name). Ups.... I think I need to delete and recreate...

UPDATE: when I change Docker repository name the example will be the following:

pgrouting/pgrouting:postgresql-10-pgrouting-2.6.1

@dkastl
Copy link
Member Author

dkastl commented Oct 18, 2018

OK, feel free to recreate it.
And I understand, that tag names would be become a bit long.

How about starting with the pgRouting release number followed by PostgreSQL:

pgrouting/pgrouting:v2.6.1-psql_10

or with full name for postgresql

pgrouting/pgrouting:v2.6.1-postgresql_9.6

@cayetanobv
Copy link
Member

cayetanobv commented Oct 18, 2018

I like your ideas @dkastl . I'm going to recreate Docker repository so this is the moment to change naming system :) I choose second proposal (full name for postgresql) because psql could be confusing with CLI tool.

@cvvergara
Copy link
Member

pgrouting is used for pgrouting
https://github.com/pgRouting/pgrouting

@cayetanobv
Copy link
Member

@cvvergara this change is only for Docker repository not for Github repository. Github reposity remains as "docker-pgrouting".

@cvvergara
Copy link
Member

ah, I didnt know docker has repositories, so much for my docker knowledge ;)

@cayetanobv
Copy link
Member

Builded images with new tags. New repository created.

@cvvergara
Copy link
Member

@cayetanobv
How are you handling the changes that are taking place on v3.0.0-dev, almost everyday there is a PR?

@dkastl
Copy link
Member Author

dkastl commented Oct 24, 2018

There should be a way to automate this, but I had to study a bit how to set this up. Anyone knows how to do?
https://docs.docker.com/docker-hub/github/#github-organizations

@cvvergara
Copy link
Member

I will open another issue with this topic change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants