Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic builds for 3.0.0-dev #4

Open
cvvergara opened this issue Oct 24, 2018 · 6 comments
Open

Automatic builds for 3.0.0-dev #4

cvvergara opened this issue Oct 24, 2018 · 6 comments

Comments

@cvvergara
Copy link
Member

How are changes to 3.0.0-dev being handled?
Because almost everyday there is a PR

@dkastl says

There should be a way to automate this, but I had to study a bit how to set this up. Anyone knows how to do?
https://docs.docker.com/docker-hub/github/#github-organizations

@cayetanobv
Copy link
Member

@dkastl @cvvergara Yes, there is a way. We can do this using build triggers so we can run our automated builds by sending a POST request to DockerHub API. I have already activated "Build Triggers" in our pgrouting Docker repository and we have a Token to use for this purpose. We can call Docker API from TravisCI.

I explain you how it works this API with several examples:

# Trigger all tags/branchs for this automated build.
$ curl -H "Content-Type: application/json" --data '{"build": true}' -X POST https://registry.hub.docker.com/u/pgrouting/pgrouting/trigger/{here-we-include-our-token}/

# Trigger by docker tag name
$ curl -H "Content-Type: application/json" --data '{"docker_tag": "master"}' -X POST https://registry.hub.docker.com/u/pgrouting/pgrouting/trigger/{here-we-include-our-token}/

# Trigger by Source branch named staging
$ curl -H "Content-Type: application/json" --data '{"source_type": "Branch", "source_name": "staging"}' -X POST https://registry.hub.docker.com/u/pgrouting/pgrouting/trigger/{here-we-include-our-token}/

# Trigger by Source tag named v1.1
$ curl -H "Content-Type: application/json" --data '{"source_type": "Tag", "source_name": "v1.1"}' -X POST https://registry.hub.docker.com/u/pgrouting/pgrouting/trigger/{here-we-include-our-token}/

@dkastl
Copy link
Member

dkastl commented Oct 25, 2018

Now the remaining question is: do we want to build a new docker image version (and tag?) with every commit to the develop branch?

What's the benefit? Who would benefit? Is there demand for this? Would someone use it actually, or do we just do it, because we can do it ;-)

I think CI could be a reason, but we are already using Travis for that. If there is no reason to do automated builds that frequently, then we could still try to automate the whole process, but maybe we should only do this then for tagged releases.

@cayetanobv
Copy link
Member

This is a very good question :-) We can do that but I don't know what people wants. People always can build locally images clonning Github repository instead of download prebuilded images from Docker hub.
Anyway, the main goal of docker-pgrouting "subproject" is to mantain images for each release. Maybe we can announce in dev or users email list this new initiative and ask to community about possibilities for "develop" branch and automated builds.

@dkastl
Copy link
Member

dkastl commented Sep 15, 2019

#15 seems to be related.

@dkastl
Copy link
Member

dkastl commented Jun 30, 2020

@cayetanobv , has this issue been eventually resolved already?

@cayetanobv
Copy link
Member

When we merge master branch of this repository (docker-pgrouting) all builds are launched. If we want in the future to automate builds with each merge of master (or develop) branch at pgrouting main repository we probably need to move this repository as a folder inside pgrouting repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants