Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouseY reference example issue #583

Open
DavideConficconi opened this issue Oct 7, 2024 · 3 comments
Open

mouseY reference example issue #583

DavideConficconi opened this issue Oct 7, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@DavideConficconi
Copy link

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Mac OS

Web browser and version

Firefox 131.0 ID build 20240923135042

Actual Behavior

First example of the reference should has no line drawn

Expected Behavior

describe("A horizontal black line moves up and down following the mouse's y-position.");
The solution is just a simple change "line(0, mouseY, 0, mouseY);" --> line(0, mouseY, 100, mouseY);

or change that 100 to whatever is the canvas dimension

Steps to reproduce

https://p5js.org/reference/p5/mouseY/

https://github.com/processing/p5.js/blob/7d393ec4215ce20f7bc3178b779e0ec67689f928/src/events/mouse.js#L250C6-L250C33

Would you like to work on the issue?

yes, didnt had the time to read how to contribute properly, was a simple resolution

@DavideConficconi DavideConficconi added the Bug Something isn't working label Oct 7, 2024
@limzykenneth
Copy link
Member

Thanks @DavideConficconi

Changes to the reference content needs to be made on the p5.js library repo, specifically this line: https://github.com/processing/p5.js/blob/v1.11.0/src/events/mouse.js#L250, so that it can persists across version or it will be overwritten by new releases.

@shourysingh07
Copy link
Contributor

@DavideConficconi I would like to work on this issue, can you assign it to me ?

@shourysingh07
Copy link
Contributor

shourysingh07 commented Oct 13, 2024

Hi @limzykenneth @davepagurek @Qianqianye ! I've opened a pull request addressing this issue within p5.js library repo.

Here is the PR Link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants