Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate the ego-server code from different repo to dcr #40

Open
qascade opened this issue May 19, 2023 · 4 comments
Open

refactor: migrate the ego-server code from different repo to dcr #40

qascade opened this issue May 19, 2023 · 4 comments

Comments

@qascade
Copy link
Owner

qascade commented May 19, 2023

Description

Currently the server code is on a different repo and is deployed separately. I want both the repos to be merged and a flag to be added on the dcr run cmd to specify that we want to run on server mode or local mode. The server code is to be refactored to make it maintainable as well as idiomatic.

Server Code: https://github.com/tiklup11/dcr_ego_server

@qascade qascade changed the title migration: Migrate the ego-server code from different repo to dcr refactor: Migrate the ego-server code from different repo to dcr May 19, 2023
@qascade
Copy link
Owner Author

qascade commented May 19, 2023

You can run the server using go run main.go in the server repo. Then change the url inside service/client.go to https://localhost:8080. Then the dcr cli can be used as a client

@qascade qascade changed the title refactor: Migrate the ego-server code from different repo to dcr refactor: migrate the ego-server code from different repo to dcr May 21, 2023
@chrisboban
Copy link

@qascade please assign this issue to me

@qascade
Copy link
Owner Author

qascade commented May 22, 2023

@chrisboban Cool. This issue is yours. Please make sure you read the guidelines and commit conventions. Please let me know if you have any questions. Name the branch migrate.ego_server

@qascade
Copy link
Owner Author

qascade commented May 26, 2023

Hey @chrisboban, any updates on the pr? Let me know if you are facing any blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants