Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The database migration might not run in some scenarios #689

Closed
sbchaos opened this issue Dec 14, 2022 · 0 comments · Fixed by #696
Closed

The database migration might not run in some scenarios #689

sbchaos opened this issue Dec 14, 2022 · 0 comments · Fixed by #696
Labels
bug Something isn't working

Comments

@sbchaos
Copy link
Contributor

sbchaos commented Dec 14, 2022

Describe the bug
We are comparing the current optimus version and the previous version to decide whether to run migration or not. But the version is string so, the comparison behaviour is not guaranteed.
eg 0.4.0-rc1 is greater than 0.4.0

Expected behavior
Migrations should run on the deployment of new release.
@sbchaos sbchaos added the bug Something isn't working label Dec 14, 2022
@sbchaos sbchaos linked a pull request Jan 10, 2023 that will close this issue
refactor: remove gorm, use pgx for postgres #696
Merged
@sbchaos sbchaos closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove gorm, use pgx for postgres raystack/optimus
1 participant
@sbchaos