Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Two-Marker Slider and Floating Labels in Form Input #8

Open
HariAcidReign opened this issue Apr 20, 2021 · 3 comments
Open

Comments

@HariAcidReign
Copy link

HariAcidReign commented Apr 20, 2021

Is your feature request related to a problem? Please Describe.

Feature Proposal Issues from RNE:
react-native-elements/react-native-elements#15
react-native-elements/react-native-elements#94
Both these new features were either closed or inactive in RNE. So, adding them here made sense.

Describe the solution you'd like

For the slider component, we can use: https://github.com/ptomasroos/react-native-multi-slider
And for the floating label, we can either use https://www.npmjs.com/package/react-native-floating-label-input or just create the component on our own using Animated API.

Additional context

I'm just putting out these ideas here. I'll be implementing these (if they get the go-ahead) immediately after I complete implementing DataTable and Carousel which I had requested earlier. As usual, will add these components to RNE App once completed.

Open to comments and other methods of implementation.

@saksham-tiwari
Copy link

@HariAcidReign Do you think we should be adding a multi slider in RNE itself rather than using https://github.com/ptomasroos/react-native-multi-slider ? If yes, should I try and work on it?

@HariAcidReign
Copy link
Author

The library is not outdated, so IMO it's not necessary. Nevertheless, ask for Pranshu sir's opinion regarding this if you want to take it forward. @saksham-tiwari

@saksham-tiwari
Copy link

@pranshuchittora

The library is not outdated, so IMO it's not necessary. Nevertheless, ask for Pranshu sir's opinion regarding this if you want to take it forward. @saksham-tiwari

@pranshuchittora sir, your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants