Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix formatting for Harshdev098's PRs #1784

Open
16 tasks
dougaitken opened this issue Jan 3, 2024 · 4 comments
Open
16 tasks

[Bug] Fix formatting for Harshdev098's PRs #1784

dougaitken opened this issue Jan 3, 2024 · 4 comments

Comments

@dougaitken
Copy link
Member

Hi @Harshdev098 I've opened this Issue for all this since you've helpfully opened 16 Pull Requests and I want to keep the conversation about resolving the failed checks in one place.

I haven't checked all of them but a quick look shows me you've either added more than one company, which isn't a problem overall but I prefer one addition per Pull Request. Secondly, you've changed the formatting. Please look at the Example company formatting - https://github.com/remoteintech/remote-jobs/blob/main/company-profiles/example.md - I think the main formatting error for each entry is you have capitalised the headers. The checks will fail unless they match exactly and if you remove any. If there is nothing specific, please find something. The example Example region 1/2/3 can be removed but you need a main Region included.

Go through your Pull Requests, and ensure there are no duplicate entries, and fix the section headers. If there is more than one company, please include that in the PR title.

Thanks!

https://github.com/remoteintech/remote-jobs/pulls/Harshdev098

@Harshdev098
Copy link
Contributor

@dougaitken I have commited the changes and now all the checks have been passed!

@dougaitken
Copy link
Member Author

dougaitken commented Jan 9, 2024

@Harshdev098 Hey, can you check each PR contains only the valid file changes? For example, I've checked #1765 #1766 and #1767 and all contain the addition of dave.md as well as the company mentioned. Please update each PR to remove any unrelated changes. Thanks

Edit - all PRs contain the addition of dave.md and the matched change to the readme file so please update to remove that. Thanks.

@Harshdev098
Copy link
Contributor

@dougaitken I have removed all the unrelated changes in the PRs

@dougaitken
Copy link
Member Author

Thanks @Harshdev098, they all have conflicts because of the removal but I can fix those with some time, thanks for the edits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants