Omnibox search should automatically enable/disable when users change the clipboard write permission

[tdulcet]

Bug description

Starting with Firefox 84, users can manage optional permissions for installed add-ons through the Add-ons Manager. The Omnibox search should automatically enable/disable when users change the clipboard write permission.

Steps to reproduce

1. Enable the "Integrate into address bar" option on the options page.
2. Disable the "Input data into clipboard" permission on the permissions page (see above screenshot).

Actual behavior

Omnibox searches are still enabled, but the emojis are not copied to the clipboard.

Expected behavior

Omnibox searches should be disabled or at least an error should be displayed.

System

Operating system and version: All
Browser and version: Firefox 84
Add-on version: 2.0

Possible solution

The extension can listen for browser.permissions.onAdded and browser.permissions.onRemoved API events. Note that these require at least Firefox 77.

[rugk]

Oh oh, you’re right! Was not aware of this change.

Actually, fortunately, as it was already implemented in Chrome/ium, I already implemented it when this was created in this module:
https://github.com/TinyWebEx/PermissionRequest/blob/97825931f1893968b8da13adf4513e7922fff559/PermissionRequest.js#L485-L492

Though of course it is not tested and bugs can occur…

[rugk]

Though I’m not sure whether that is really the problem/solution. Is not the settings page (re)loaded when you click “settings” in Firefox? So should not it be a fresh new site?

[rugk]

Though I’m not sure whether that is really the problem/solution. Is not the settings page (re)loaded when you click “settings” in Firefox? So should not it be a fresh new site?

Just tried myself: no it is not.