Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the names of graph structs consistent #93

Open
universato opened this issue Jun 12, 2021 · 2 comments
Open

Make the names of graph structs consistent #93

universato opened this issue Jun 12, 2021 · 2 comments

Comments

@universato
Copy link

universato commented Jun 12, 2021

main

Now: SccGraph, MfGraph, MinCostFlowGraph

  • The name style of the struct is different.

Expected1: Scc(or SCC), MaxFlow, MinCostFlow

  • Short and readable.
  • Each struct name equals each file name.

Expected2: SccGraph, MaxFlowGraph, MinCostFlowGraph

  • Long but readable.
  • No other language library has adopted this idea.

Expected3: SccGraph, MfGraph, McfGraph

  • Too short, not readable (except for SccGraph).
  • These names are closest to the original C++ library.

All graph names need to be changed, but I prefer expected1.

Other data structures

In reference,

lang struct, impl file
Rust Dsu dsu URL
Rust SccGraph scc URL
Rust MfGraph maxflow URL
Rust MinCostFlowGraph mincostflow URL
Rust Segtree segtree URL
Rust LazySegtree lazysegtree URL
Rust TwoSat twosat URL
Rust ModInt modint URL

Other language libraries

In reference,

Lang SCC MaxFlow MinCostFlow
C++ scc_graph mf_graph mcf_graph
C# SccGraph MFGraph/MaxFlow.cs McfGraph/MinCostFlow.cs
Python SCCGprah MFGraph MCFGraph
Rust SccGraph MfGraph MinCostFlowGraph
Go SccGraph --- ---
D SccGraph MfGraph McfGraph
Java SCC MaxFlow MinCostFlow
Kotolin SCC MaxFlow MinCostFlow
Ruby SCC MaxFlow MinCostFlow
Crystal SCC MaxFlow MinCostFlow
@TonalidadeHidrica
Copy link
Collaborator

This is just renaming the names, so it may be worth considering before the language update.

@TonalidadeHidrica TonalidadeHidrica changed the title Raname graph names Make the names of graph structs consistent Mar 26, 2023
@qryxip
Copy link
Member

qryxip commented Apr 8, 2023

@TonalidadeHidrica @mizar I prefer "Expected2". What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants