Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose children (slides DOM elements) list as a public interface for production version (the alias for getImgs) #42

Open
WhereJuly opened this issue Dec 17, 2018 · 1 comment

Comments

@WhereJuly
Copy link

WhereJuly commented Dec 17, 2018

Thanks for the tiny yet powerful slider.

In order to make it even more capable could you please expose the children list as a public interface (not only for testing as you do it now via getImgs: () => imgs,)?

This opens a world of new possibilities to add dots or image previews (either passive decoration or active controller elements) to the slider. Yet this update is just a minute to introduce.

This could be something like simpleslider.children array with native JS length property and all the JS array prototype functions. This would as well expose the slides' DOM elements for more customization.

@WhereJuly WhereJuly changed the title Expose children list as a public interface for production version (the alias for getImgs) Expose children (slides DOM elements) list as a public interface for production version (the alias for getImgs) Dec 17, 2018
@ruyadorno
Copy link
Owner

hi @WhereJuly this sounds like a great idea 😄 it could def make it a lot easier to extend functionality from the slider, not sure why I didn't included it from the start but I guess it has to do with cutting all the cruft in order to get it to the smallest size possible 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants