Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish TypeScript types for this package #35

Open
blimmer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #37
Open

Publish TypeScript types for this package #35

blimmer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #37

Comments

@blimmer
Copy link
Contributor

blimmer commented Nov 15, 2024

Self-explanatory. It'd be nice to have types delivered natively with this package, but we could also go the DefinitelyTyped route, as well.

@mbklein mbklein linked a pull request Nov 21, 2024 that will close this issue
@mbklein
Copy link
Member

mbklein commented Nov 21, 2024

@blimmer I've taken a stab at adding the appropriate .d.ts files. VS Code's Intellisense is picking up the types nicely in my tests, but since I'm a bit new at combining JS code and TS types in a single package, would you mind referencing the branch from a project and seeing if it's behaving as you'd expect?

"dependencies": {
  "iiif-processor": "github:samvera/node-iiif#35-add-typescript-types"
}

@blimmer
Copy link
Contributor Author

blimmer commented Nov 22, 2024

Thanks! Looking good so far. I tried this on a repo using this package and found only one issue with the streamResolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants