Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding a design review meeting before a module implementation starts #51

Open
rbrunner7 opened this issue Mar 12, 2023 · 0 comments
Open

Comments

@rbrunner7
Copy link
Member

I propose a project management improvement for our workgroup: When somebody has the design ready for some new component to implement, they don't just start to code, but we hold something like a design review meeting first. There the broad strokes of the design get presented, and discussed.

Benefits should be twofold: As building this brand-new wallet is quite hard, it can do no harm to get input and opinions from fellow workgroup members before "creating facts" by coding. And we also get improved "visibility" where we stand and what people are planning.

Some background info about what made me come up with this proposal:

We have an ongoing discussion and a sort of "post mortem" of the quite turbulent story how @DangerousFreedom1984 implemented Seraphis proofs with support from @UkoeHB. You can read details about it here.

Like I already commented there I think it's a good idea, based on experiences made, to attempt to improve some project management aspects of our workgroup. After all, it's a big and hard project, and something where we can't just easily copy what is custom in Monero development because endeavors of this magnitude are rare.

Case in point: @DangerousFreedom1984 told that he is ready to start work on a new component, the one that caches things like transactions and enotes inside the wallet.

Independently from that I started to document important aspects of the wallet interface here: #49. And while doing so I got the impression that it's everything but trivial to decide what exactly the new wallet should store, and how.

That's why I think that we should discuss the design for that component together in the first such design review meeting that I propose here: Even designing such a lowly component (only about 4 or 5 vectors and maps currently in wallet2) can be quite a challenge that may profit from teamwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant