Support for classifier configuration of Plugin artifact

[h3xstream]

I need to bundle dependencies with a SpotBugs plugin. The easiest way to publish this plugin is releasing the normal jar and a jar with all the needed dependencies.

My small obstacle is that I can't configure a classifier in the PluginArtifact XML section.

spotbugs-maven-plugin/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy

Lines 1179 to 1183 in 263bbd0

	class PluginArtifact {
	String groupId, artifactId, version
	String type = "jar"
	}

Maybe I'm missing something regarding Plugin Artifact dependencies and the all-in-one jar is not necessary.

[hazendaz]

@gleclaire Hi, I was wondering if you could take a look at this issue.

[h3xstream]

I have temporary fix that might not be ideal for end-users .. but good enough for me:

The fork parameter set to false allow spotbugs to run in the context of the Maven process.
I can then add dependencies to the spotbugs-plugin manually. Those are then available to the my detector plugin.

            <plugin>
                <groupId>com.github.spotbugs</groupId>
                <artifactId>spotbugs-maven-plugin</artifactId>
                <version>3.1.1</version>
                <configuration>
                    <fork>false</fork>
                    <timeout>9999999</timeout>
                    <effort>Max</effort>
                    <threshold>Low</threshold>
                    <failOnError>true</failOnError>
                    <includeFilterFile>${session.executionRootDirectory}/findbugs-security-include.xml</includeFilterFile>
                    <excludeFilterFile>${session.executionRootDirectory}/findbugs-security-exclude.xml</excludeFilterFile>
                    <plugins>
                        <plugin>
                            <groupId>com.h3xstream.findsecbugs</groupId>
                            <artifactId>experimental-plugin</artifactId>
                            <!--<classifier>jar-with-dependencies</classifier>--> <!-- Not supported yet -->
                            <version>1.8.0</version>
                        </plugin>
                    </plugins>
                </configuration>
                <dependencies>
                    <dependency>
                    [...]
                    <!-- List of dependencies goes here -->
                    </dependency>
                </dependencies>
            </plugin>

[hazendaz]

@h3xstream Not tested but have added classifier support for next release.