[WIP] Wallet Activity: A more reliable update #21596
Draft
+605
−440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
from
540d649
to
e3409e6
Compare
mohsen-ghafouri
approved these changes
Nov 14, 2024
mohsen-ghafouri
force-pushed
the
chore/activity-rpc-cleanup
branch
from
e3409e6
to
84a725e
Compare
how do they depend on it? the transaction RPC flow is basically about send, swap, bridge transactions — it doesn't affect how the filtering of activities is done |
|
@alwx it looks new activity filter rpc works with new send transaction rpc. to test it we need new flow to be done. |
@alwx - The new activities we will integrate into the client are locally generated by status-go in the latest transaction RPCs/Flow, not in the deprecated ones we use now. |
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
from
84a725e
to
792fd0c
Compare
smohamedjavid
changed the title
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
2 times, most recently
from
6cfce43
to
ffd3d65
Compare
…d bridge, swap and approval types status-im/status-go@032eb5b...2e3dd26 Signed-off-by: Mohamed Javid <[email protected]>
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
from
ffd3d65
to
2f85bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21583
fixes #21667
Summary
This PR:
wallet_filterActivityAsyncRPC and updates it towallet_startActivityFilterSessionV2with other supporting activity filter session RPCswallet_checkRecentHistoryForChainIDsRPC as we no longer support past transaction historyActivities.mp4
Review notes
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
Testing notes
The activities are shown only for the accounts where the activity originated from
Platforms
Steps to test
Prerequisites: A wallet account with some tokens
status: WIP