Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest better branch name when reviewing PRs #1521

Open
kaste opened this issue Dec 9, 2021 · 0 comments
Open

Suggest better branch name when reviewing PRs #1521

kaste opened this issue Dec 9, 2021 · 0 comments

Comments

@kaste
Copy link
Collaborator

kaste commented Dec 9, 2021

If I just hit enter enough, I end up with e.g.

image

T.i. obviously the branch name has the remote name duplicated. What we probably want is also a backlink to the PR (a clickable link would be 👍, at least the number 🙏)

  • # signs are not forbidden, t.i. master-#310 would be allowed, though weird. (#123-master is not allowed.)

So we have either 310-master or e.g. master-310 or master-#310. master is the branch name the contributor used; these are very often nonsensical, like master, patch-1 etc. (patch-1 would become patch-1-#23, ugly but useful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant