Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve grep heuristics #307

Open
dvmarcilio opened this issue Dec 29, 2022 · 0 comments
Open

Improve grep heuristics #307

dvmarcilio opened this issue Dec 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dvmarcilio
Copy link
Collaborator

Currently, looks like the grep heuristics do an or of the arguments in piranha_arguments.toml.

Based on an offline discussion, one improvement might be to consider the holes of each rule in rules.toml.
@ketkarameya ketkarameya added bug Something isn't working and removed polyglot-piranha labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvmarcilio @ketkarameya