Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang Risk with Beethoven > InputSignalTracker.swift > start() #79

Open
curtinmjc opened this issue Jan 19, 2023 · 1 comment
Open

Hang Risk with Beethoven > InputSignalTracker.swift > start() #79

curtinmjc opened this issue Jan 19, 2023 · 1 comment

Comments

@curtinmjc
Copy link

When running GuitarTuner on multiple, different iOS devices (iPhone, iPad), there is a Hang Risk issue raised each time InputSignalTracker's start() method is called.

  • line of code: 84
  • code: captureSession.startRunning()
  • issue: -[AVCaptureSession startRunning] should be called from background thread. Calling it on the main thread can lead to UI unresponsiveness
  • Build Settings - Swift Language Version: Swift 5
  • iOS Deployment Target: iOS 12.0
  • Xcode Version: 14.2
  • iPhone & iPad iOS Version: 16.2

This also happens with my own app when using Beethoven audio processing Swift library.

@lindezhen
Copy link

DispatchQueue.global(qos: .userInitiated).async {
self.captureSession.startRunning()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants