Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impossible to auth #65 #107

Closed
wants to merge 2 commits into from
Closed

Fix impossible to auth #65 #107

wants to merge 2 commits into from

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Aug 6, 2021

Describe your feature

  • this PR was checked by golangci-linter
  • new code did not break current interfaces
  • all comments were written on american english language
  • all commit messages are spiced up with emojis, which wa defined in CG and in .gitmessage

Fix decoding received data: Server response error: (code 4294966892)"

Resolves #65

Main purpose

Possible issues

@quenbyako
Copy link
Member

@waybackarchiver I appreciate your contribuition to mtproto (i mean, this is honest, mtproto is really hungry for maintainers and contributors), but invoking is already defined here, in NewClient() function. According to telegram api definition, looks like InvokeWithLayer must call once per tcp session, soooo, yeah, this method call might be unnecessary.

Even though, if this pr fixes your problem, might be that i fucked up somewhere, so i won't close this pr, and test it (i promise, one day or another, i'll do it. Or new maintainer will come 🥴)

@quenbyako quenbyako added the good first PR Awesome PRs of newcomers label Aug 6, 2021
@waybackarchiver
Copy link
Contributor Author

@quenbyako You are right. I repeatedly tested and found that the current approach to be reasonable. This PR's changes will only send SMS codes for verifying, and cause the session can not be reused. Probably best to close this PR so as not to mislead others.

@quenbyako
Copy link
Member

@waybackarchiver anyway, if you have any bug or problem, and fixed it somehow, feel free to create new PRs, we will try to find a good solution together)

I've tested this PR, and didn't find any differences from current behavior, so i'll close it. If you think that this one is better to reopen, as well, feel free to note me about that)

@quenbyako quenbyako closed this Aug 6, 2021
@waybackarchiver waybackarchiver deleted the example-auth branch August 6, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first PR Awesome PRs of newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Impossible to auth
2 participants