Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picture can't be dragged #1

Open
nwtn opened this issue Apr 17, 2013 · 0 comments
Open

picture can't be dragged #1

nwtn opened this issue Apr 17, 2013 · 0 comments

Comments

@nwtn
Copy link

nwtn commented Apr 17, 2013

<picture> can't be dragged, which causes problems for drag-and-drop (e.g. dragging a picture into a contenteditable region).
yoavweiss pushed a commit that referenced this issue Jul 11, 2013
Revert "Rewrite parseFrameSetListOfDimension to match HTML5"
41ba31c 
The change has resulted in ASAN failures:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/7635/steps/webkit_tests/logs/stdio

==2535==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000176835 at pc 0x5b315d5 bp 0x7fffeec0d570 sp 0x7fffeec0d568
READ of size 1 at 0x604000176835 thread T0 (content_shell)
       #0 0x5b315d4 in WebCore::Length WebCore::parseDimension<unsigned char>(unsigned char const*, unsigned long, unsigned long) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:62:0
       #1 0x5b3111b in WebCore::parseDimension(WTF::String const&, unsigned long, unsigned long) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:97:0
       #2 0x5b30fab in WebCore::parseListOfDimensions(WTF::String const&) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:129:0
       #3 0x5a4ae7f in WebCore::HTMLFrameSetElement::parseAttribute(WebCore::QualifiedName const&, WTF::AtomicString const&) ../third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp:84:0

This reverts commit ac7e5c0.

[email protected]

Review URL: https://codereview.chromium.org/18565005

git-svn-id: svn://svn.chromium.org/blink/trunk@154013 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 23, 2013
Remove AtomicStringImpl.
b88d447 
This is attempt #2. Attempt #1 was reverted due to some object lifetime issues
which were tackled in separate bugs.

I also noted the paradigm of RefPtr<AtomicStringImpl> as a map key, which I
replaced with functionally-equivalent AtomicString. This may have the advantage
of less template specializations.

BUG=250050
TEST=layout tests under ASAN ok

Review URL: https://chromiumcodereview.appspot.com/19804005

git-svn-id: svn://svn.chromium.org/blink/trunk@154790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 29, 2013
[CSS Shapes] Port shape-inside on regions and shape's content overflo…
9d3c595 
…w from WebKit

This change covers a set of smaller fixes that were landed in WebKit regarding to shape-inside on regions and content overflow from shape-inside.

Merged revisions:
- #1  http://trac.webkit.org/changeset/148975
- #2  http://trac.webkit.org/changeset/149857
- #3  http://trac.webkit.org/changeset/150027
- #4  http://trac.webkit.org/changeset/150375
- #5  http://trac.webkit.org/changeset/150478
- #6  http://trac.webkit.org/changeset/151570
- #7  http://trac.webkit.org/changeset/151652
- #8  http://trac.webkit.org/changeset/151703
- #9  http://trac.webkit.org/changeset/152772
- #10 http://trac.webkit.org/changeset/152904
- #11 http://trac.webkit.org/changeset/152906
- #12 http://trac.webkit.org/changeset/152925
- #13 http://trac.webkit.org/changeset/153053

[email protected]
BUG=262269

Review URL: https://chromiumcodereview.appspot.com/19865002

git-svn-id: svn://svn.chromium.org/blink/trunk@155098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 29, 2013
[CSS Shapes] Fix Shapes's polygon tests
8952259 
Shapes's polygon tests didn't run because of a typo and some missing js include.

Merged revisions:
- #1 http://trac.webkit.org/changeset/153338
- #2 http://trac.webkit.org/changeset/153350

Review URL: https://chromiumcodereview.appspot.com/20489004

git-svn-id: svn://svn.chromium.org/blink/trunk@155102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 6, 2013
IndexedDB: Have IDBCursor and IDBRequest explicitly break ref cycles
4b8ab16 
Until (1) a transaction ends or (2) a cursor hits the end of its
range, an IDBRequest holds on to an IDBCursor as its result. Per spec,
calling continue() or advance() on the cursor re-uses the same
IDBRequest, requiring a reference cycle.

Previously, the cycle was broken explicitly on either of those two
conditions, but until that time a cursor-request pair would "leak",
holding on to potentially large script value results.

This patch makes both classes RefCountedBase::deref() and check
to see if they have a partner object and both refcounts are 1. If
so, the cycle is broken.

Special case cruft for condition #1 is removed to simplify the
code - just rely on GC to reclaim the objects if necessary.

[email protected],[email protected]
BUG=225860

Review URL: https://chromiumcodereview.appspot.com/23653024

git-svn-id: svn://svn.chromium.org/blink/trunk@157382 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 2, 2014
Use PartitionAlloc for fastMalloc on Android
3b994c5 
This switches fastMalloc to PartitionAlloc for Android. Previously, we only
used PartitionAlloc for fastMalloc on Mac OS X.

According to primiano's measurements, this CL should improve PLT performance
on Android by 7%.  See referenced bug for details.

alexa_us on N10 with default alloc (without
#     ms/page  PSS   Dirty
#1    227.6   60410 44904
#2    226.1   61547 46008
#3    222.4   55595 40072
#4    224.2   57293 41728
AVG   225.1   58711 43178

alexa_us on N10 with partalloc
#     ms/page  PSS   Dirty
#1    204.68  54862  39456
#2    208.73  59240  43844
#3    208.57  55164  39788
#4    217.28  58280  42904
AVG   209.81  56886  41498

BUG=312725
[email protected]

Review URL: https://codereview.chromium.org/148013010

git-svn-id: svn://svn.chromium.org/blink/trunk@166271 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 4, 2014
MediaStream API: Patch #1 of implementing navigator.getMediaDevices
f3dea58 
The deprecated MediaStreamTrack.getSources()  will be removed later.
This patch contains almost everything except .idl files which means that this is "dead" code which will not affect anything.
Patch 2 will introduce mock support for getMediaDevices.
And finally the third patch will add tests and idl files.

BUG=338511

Review URL: https://codereview.chromium.org/135363004

git-svn-id: svn://svn.chromium.org/blink/trunk@166370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 5, 2014
Fixed crash on Android tcmalloc builds caused by vasprintf being inco…
311405a 
…mpatible to tcmalloc

[email protected]
TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash.

********** Crash dump: **********
Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys'
pid: 3431, tid: 3444  >>> org.chromium.content_shell_apk:sandboxed_process1 <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039
Stack frame #00  pc 02263b44  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15
Stack frame #1  pc 0226ccd8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120
Stack frame #2  pc 0227584c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0
Stack frame #3  pc 02277698  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166
Stack frame #4  pc 02277898  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209
Stack frame #5  pc 0229f914  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569
Stack frame #6  pc 0158af50  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0
Stack frame #7  pc 0158aff8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305
Stack frame #8  pc 01166dac  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572
Stack frame #9  pc 0116b7a8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0
Stack frame #10  pc 0117e424  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453
Stack frame #11  pc 0117ea88  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767
Stack frame #12  pc 0158891c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0
Stack frame #13  pc 01589da0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876
Stack frame #14  pc 01589f3c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49
Stack frame #15  pc 00d07e70  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #16  pc 015770bc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #17  pc 017bdd20  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47
Stack frame #18  pc 017bddc8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219
Stack frame #19  pc 00eb86d8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110
Stack frame #20  pc 01024b5c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443
Stack frame #21  pc 010304c8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971
Stack frame #22  pc 010305dc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845
Stack frame #23  pc 00fb12f8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875
Stack frame #24  pc 00fb1b78  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076
Stack frame #25  pc 00fb1bd0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0

Review URL: https://codereview.chromium.org/143903018

git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 18, 2014
DevTools: Simplify mergeOrIntersect
86fa1f8 
Drive by:
1. The original mergeOrIntersect had a bug causing e.g. []x[1,2,3] produce [1,2,3].
2. findFilesMatchingSearchRequest had a bug that relied on #1 and produced almost correct results.

Both are fixed with this patch.

[email protected], [email protected]

Review URL: https://codereview.chromium.org/166703003

git-svn-id: svn://svn.chromium.org/blink/trunk@167282 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 6, 2014
Revert 168384 "Use OwnPtrs for heap contains cache and persisten..."
de83ddd 
Revert 168384 as it caused a serious crash (top #1 crasher on mac).

BUG=349842

> Use OwnPtrs for heap contains cache and persistent anchor. We were leaking the HeapContainsCache.
> 
> [email protected], [email protected]
> BUG=348629
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/183683017

[email protected]

Review URL: https://codereview.chromium.org/180723022

git-svn-id: svn://svn.chromium.org/blink/trunk@168676 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 14, 2014
Remove unnecassary parameter "sampleRate" for loadAudioResource().
920c823 
Parameter "sampleRate" is not required for loadAudioResource().
There is FIXME in AudioBus.cpp in blink
FIXME: the sampleRate parameter is ignored. It should be removed from the API.

It will be consist of 3 steps. 
1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method) 
https://codereview.chromium.org/195043002/ 

2. Removing "sampleRate" in blink. 
https://codereview.chromium.org/194753005/ 

3. Removing deprecated method from #1 

BUG=351284

Review URL: https://codereview.chromium.org/194753005

git-svn-id: svn://svn.chromium.org/blink/trunk@169188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 27, 2014
Revert of Make start/stop loading notifications per-frame (https://co…
d6b8933 
…dereview.chromium.org/183793002/)

Reason for revert:
Possibly causing content_browsertests EndToEnd to fail.

See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio

Output:
[20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0)
[20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28)
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x000000a593be base::debug::StackTrace::StackTrace()
#1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9c3e4ab4a0 <unknown>
#3 0x7f9c3e55da43 __poll
#4 0x7f9c42aabff6 <unknown>
#5 0x7f9c42aac124 g_main_context_iteration
#6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
#7 0x000000a8e802 base::RunLoop::Run()
#8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread()

Original issue's description:
> Make start/stop loading notifications per-frame
> 
> Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.
> 
> This depends on https://codereview.chromium.org/180113003/ landing in chromium.
> 
> BUG=347643
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=347643

Review URL: https://codereview.chromium.org/215533004

git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 28, 2014
Revert of Revert of Make start/stop loading notifications per-frame (h…
28a1ff6 
…ttps://codereview.chromium.org/215533004/)

Reason for revert:
r170192 was not a culprit.


Original issue's description:
> Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/)
> 
> Reason for revert:
> Possibly causing content_browsertests EndToEnd to fail.
> 
> See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio
> 
> Output:
> [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0)
> [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28)
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x000000a593be base::debug::StackTrace::StackTrace()
> #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f9c3e4ab4a0 <unknown>
> #3 0x7f9c3e55da43 __poll
> #4 0x7f9c42aabff6 <unknown>
> #5 0x7f9c42aac124 g_main_context_iteration
> #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
> #7 0x000000a8e802 base::RunLoop::Run()
> #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread()
> 
> Original issue's description:
> > Make start/stop loading notifications per-frame
> > 
> > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.
> > 
> > This depends on https://codereview.chromium.org/180113003/ landing in chromium.
> > 
> > BUG=347643
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192
> 
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=347643
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=347643

Review URL: https://codereview.chromium.org/216083002

git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 28, 2014
Revert of Make DOMWrapperWorld::current() return a reference instead …
0f588d3 
…of a pointer (https://codereview.chromium.org/209713003/)

Also reverting dependent patch https://codereview.chromium.org/213543004

Reason for revert:
Likely to have caused memory leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1

(1)
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
    #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
    #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
    #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132

(2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
    #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
    #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
 
(3)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
    #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
    #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
    #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
    #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53

Original issue's description:
> Make DOMWrapperWorld::current() return a reference instead of a pointer
> 
> Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> 
> BUG=341032
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=341032

Review URL: https://codereview.chromium.org/217053007

git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 31, 2014
Revert 170357 "Revert of Make DOMWrapperWorld::current() return ..."
8961684 
This is a revert of the revert of r170261.
r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive.

> Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/)
> 
> Also reverting dependent patch https://codereview.chromium.org/213543004
> 
> Reason for revert:
> Likely to have caused memory leaks:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1
> 
> (1)
> Direct leak of 32 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
>     #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
>     #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
>     #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
> 
> (2)
> Indirect leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
>     #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
>     #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
>  
> (3)
> Indirect leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
>     #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
>     #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
>     #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
>     #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
>     #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
> 
> Original issue's description:
> > Make DOMWrapperWorld::current() return a reference instead of a pointer
> > 
> > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> > 
> > BUG=341032
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261
> 
> [email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=341032
> 
> Review URL: https://codereview.chromium.org/217053007

[email protected]

Review URL: https://codereview.chromium.org/218813002

git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Apr 4, 2014
Interface cleanup for WebGestureCurveTarget
e28d1db 
This is the final patch in a three-part series towards early termination of
flings when scrolling is impossible, cleaning up now unused portions of the
WebGestureCurveTarget interface.

Blink patch (#1)
https://codereview.chromium.org/139493003/

Chromium patch (#2):
https://codereview.chromium.org/136173004/

Review URL: https://codereview.chromium.org/217893004

git-svn-id: svn://svn.chromium.org/blink/trunk@170887 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 12, 2014
Handle initial values in background-repeat introduced by the backgrou…
05eca13 
…nd shorthand

background-repeat serialization did not handle initial keyword values in
background-repeat value lists.
Initial values in value lists are introduced by setting the background
shorthand to multiple background values while omitting background-repeat
properties.
Example: background: url(#1), url(#2), url(#3);
The background-repeat gets stored internally as "initial, initial, initial".

This patch updates StylePropertySerializer::backgroundRepeatPropertyValue()
to handle this case correctly.

BUG=378167

Review URL: https://codereview.chromium.org/303993003

git-svn-id: svn://svn.chromium.org/blink/trunk@175261 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 12, 2014
ServiceWorker: Add a Response ctor that accepts the body as a Blob
18fe14c 
This ctor is expected to be added to the spec:
w3c/ServiceWorker#192

Eventually we'll also have ctors for String, Stream, and
ArrayBuffer bodies.

Multi-sided patch to implement blob-type fetch event
response bodies:
#1: blink-side, THIS PATCH
#2: chromium-side: https://codereview.chromium.org/304153015/
#3: blink-side: https://codereview.chromium.org/304233017

BUG=379074

Review URL: https://codereview.chromium.org/307063002

git-svn-id: svn://svn.chromium.org/blink/trunk@175350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 16, 2014
Revert of IDL: Support optional argument default value syntax (https:…
4a1fd1c 
…//codereview.chromium.org/312683005/)

Reason for revert:
This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
#1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f2c232cd4a0 \u003Cunknown>
#3 0x7f2c2337f313 __poll
#4 0x7f2c240b6036 \u003Cunknown>
#5 0x7f2c240b6164 g_main_context_iteration
#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
#8 0x7f2c2a2f69d8 base::RunLoop::Run()
#9 0x00000466bd59 content::RunThisRunLoop()
#10 0x00000466c1b8 content::MessageLoopRunner::Run()
#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
#12 0x0000011fdf00 MediaBrowserTest::RunTest()
#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
...

Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.

Original issue's description:
> IDL: Support optional argument default value syntax
> 
> Adds support for parsing default values of different types, but
> only handles null default values when generating code.
> 
> Replaces existing
> 
>   [Default=Null] optional SomeInterface arg
>   [Default=NullString] optional DOMString arg
> 
> with the now equivalent
> 
>   optional SomeInterface arg = null
>   optional DOMString arg = null
> 
> in IDL files, and drops support for those [Default] attributes.
> 
> No changes to generated code.
> 
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339683002

git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 16, 2014
Revert of Revert of IDL: Support optional argument default value synt…
356a3bd 
…ax (https://codereview.chromium.org/339683002/)

Reason for revert:
Revert the revert because the bot went green even without this revert, and other bots had no trouble.

Original issue's description:
> Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)
> 
> Reason for revert:
> This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
> #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f2c232cd4a0 \u003Cunknown>
> #3 0x7f2c2337f313 __poll
> #4 0x7f2c240b6036 \u003Cunknown>
> #5 0x7f2c240b6164 g_main_context_iteration
> #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
> #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
> #8 0x7f2c2a2f69d8 base::RunLoop::Run()
> #9 0x00000466bd59 content::RunThisRunLoop()
> #10 0x00000466c1b8 content::MessageLoopRunner::Run()
> #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
> #12 0x0000011fdf00 MediaBrowserTest::RunTest()
> #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
> #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
> #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
> #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
> ...
> 
> Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.
> 
> Original issue's description:
> > IDL: Support optional argument default value syntax
> > 
> > Adds support for parsing default values of different types, but
> > only handles null default values when generating code.
> > 
> > Replaces existing
> > 
> >   [Default=Null] optional SomeInterface arg
> >   [Default=NullString] optional DOMString arg
> > 
> > with the now equivalent
> > 
> >   optional SomeInterface arg = null
> >   optional DOMString arg = null
> > 
> > in IDL files, and drops support for those [Default] attributes.
> > 
> > No changes to generated code.
> > 
> > BUG=258153
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339723002

git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 18, 2014
DevTools: [Console] fix certain case that forces console to shake
bab0662 
Currently, ViewportControl uses clientHeight of its main element to
estimate visible viewport height. This falls shortly under the following
scenario:
1. ViewportControl has its "stickToBottom" flag set to true and just
scrolled to bottom as its "refresh" method got executed. Note, that
this refresh has scheduled one more scroll as it "scrolls to bottom".
2. The "refresh" method call figured out that there's a necessity to
render one more element in the beginning of viewport, and this new
element happen to add a horizontal scroll to the console.
3. Another "refresh" method gets executed (it was scheduled in #1)
4. The method figures out that client height changed (due to added
horizontal scroller), thus first element not needed any more and
gets removed from viewport.
5. Goto #1.

This change migrates from using clientHeight to using offsetHeight
which doesn't change as horizontal scroller gets added or removed in
result of viewport rendering.

BUG=387465

Review URL: https://codereview.chromium.org/396853005

git-svn-id: svn://svn.chromium.org/blink/trunk@178422 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 14, 2014
Revert of LeakDetector: Add an expectation for resolve-after-window-c…
4c7e9b9 
…lose.html (patchset #1 of https://codereview.chromium.org/460213002/)

Reason for revert:
Fixed by http://src.chromium.org/viewvc/blink?view=revision&revision=180139

Original issue's description:
> LeakDetector: Add an expectation for resolve-after-window-close.html
> 
> r179771 fixed the crash bug but it didn't fix the leak bug.
> 
> BUG=400012
> TEST=n/a
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180028

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=400012

Review URL: https://codereview.chromium.org/475593003

git-svn-id: svn://svn.chromium.org/blink/trunk@180221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 15, 2014
Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables a…
77d4231 
…ction (patchset #1 of https://codereview.chromium.org/463063003/)

Reason for revert:
This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build.

The problem fixed by this CL was cosmetic only, so is not worth the risk.

Original issue's description:
> Add lextab.pyc as an output of the cached_lex_yacc_tables action
> 
> The primary output is lextab.py, but since it is imported, Python also
> writes lextab.pyc. Listing it too as an output means it won't be left
> around by "ninja -t clean" (and not much else, I think.)
> 
> Prior to the patch
>   https://codereview.chromium.org/425953002/
> the result of not having lextab.pyc listed as an output and running
> "ninja -t clean" was a tree that would build correctly, but that would
> always rerun all the IDL code generation scripts, and thus never become
> "clean".
> 
> BUG=397909
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=397909

Review URL: https://codereview.chromium.org/468743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180329 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 19, 2014
Revert of Oilpan: Move more code of RenderObject destructors to destr…
dd2eff3 
…oy(). (patchset #1 of https://codereview.chromium.org/459353002/)

Reason for revert:
Caused crashes in ImageQualityController::highQualityRepaintTimerFired().


Original issue's description:
> Oilpan: Move more code of RenderObject destructors to destroy().
> 
> Like [1] and [2]. We should do it in general.
> 
> [1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023
> [2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029
> 
> BUG=398342
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180046

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398342

Review URL: https://codereview.chromium.org/478923005

git-svn-id: svn://svn.chromium.org/blink/trunk@180424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 19, 2014
Revert of Mark link-rel-prefetch-and-subresource flaky (patchset #1 of …
6eaa1e0 
…https://codereview.chromium.org/431153003/)

Reason for revert:
Bug fixed.

Original issue's description:
> Mark link-rel-prefetch-and-subresource flaky
> 
> [email protected]
> NOTRY=true
> BUG=399459
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179348

Review URL: https://codereview.chromium.org/480083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180481 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 20, 2014
Revert of Add logging for ScriptedAnimationController. (patchset #1 of …
8c4658f 
…https://codereview.chromium.org/484323002/)

Reason for revert:
Broke https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20(dbg)/builds/33277/steps/compile/logs/stdio

Original issue's description:
> Add logging for ScriptedAnimationController.
> 
> This is for debugging RAF based WebGL conformance tests random timeouts.
> 
> BUG=393331
> TEST=bots
> NOTRY=true
> [email protected],[email protected]
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180672

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=393331

Review URL: https://codereview.chromium.org/488863004

git-svn-id: svn://svn.chromium.org/blink/trunk@180682 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 21, 2014
Revert of [DevTools] Add interstitial events to Inspector domain. (pa…
e269c8b 
…tchset #1 of https://codereview.chromium.org/476423003/)

Reason for revert:
Causes JS compiler errors

Original issue's description:
> [DevTools] Add interstitial events to Inspector domain.
> 
> BUG=404631
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180666

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=404631

Review URL: https://codereview.chromium.org/488413002

git-svn-id: svn://svn.chromium.org/blink/trunk@180699 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
@inexorabletash
Revert of Revert of ServiceWorker: throw when close() or terminate() …
5547e68 
…called (patchset #1 of https://codereview.chromium.org/515323002/)

Reason for revert:
The CL reverted by this patchset was not responsible for the breakage. Re-landing.

Original issue's description:
> Revert of ServiceWorker: throw when close() or terminate() called (patchset #3 of https://codereview.chromium.org/505063002/)
> 
> Reason for revert:
> Break compilation on various bots. Maybe Win only.
> 
> Original issue's description:
> > ServiceWorker: throw when close() or terminate() called
> > 
> > Per spec:
> > * ServiceWorker#terminate() should throw InvalidAccessError
> > * ServiceWorkerGlobalScope#close() should throw InvalidAccessError
> > 
> > ... since the behaviors inherited from the base interfaces are not
> > supported.
> > 
> > Spec: slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html
> > 
> > BUG=398318
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181049
> 
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=398318
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181050

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398318

Review URL: https://codereview.chromium.org/513353002

git-svn-id: svn://svn.chromium.org/blink/trunk@181057 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 9, 2014
@jianli-chromium
Revert of Revert of HTMLConstructionSite: avoid n^2 running time for …
c0f57ff 
…large scripts. (patchset #1 id:1 of https://codereview.chromium.org/555223002/)

Reason for revert:
Not a culprit. Reverted to bring back the original patch.

Original issue's description:
> Revert of HTMLConstructionSite: avoid n^2 running time for large scripts. (patchset #5 id:80001 of https://codereview.chromium.org/494993002/)
> 
> Reason for revert:
> Speculative revert.
> 
> It may break the following blink sheriff bot:
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21403
> 
> 
> 
> Original issue's description:
> > HTMLConstructionSite: avoid n^2 running time for large scripts.
> > 
> > Every time background parser sends chunk, tree is flushed.
> > 
> > If page contains very large script, then script node content is updated
> > many times. Every update is causes string concatenation.
> > 
> > Solution: do not flush pending text until it is mandatory.
> > 
> > Test: https://codereview.chromium.org/500363002
> > Test depends on: https://codereview.chromium.org/544453004/
> > 
> > BUG=410790
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181635
> 
> [email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=410790
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181664

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=410790

Review URL: https://codereview.chromium.org/558743002

git-svn-id: svn://svn.chromium.org/blink/trunk@181668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 10, 2014
@mikewest
Revert of Remove some CSS properties from UseCounters (patchset #1 id…
6be1213 
…:1 of https://codereview.chromium.org/558473002/)

Reason for revert:
We don't want to remove properties that we still support.

Original issue's description:
> Remove some CSS properties from UseCounters
> 
> All of these measure stable features except CSSPropertyWebkitCursorVisibility which
> is actually removed.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181680

[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/559073002

git-svn-id: svn://svn.chromium.org/blink/trunk@181731 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@mikewest
Revert of Revert of Mixed Content: Move subframe checks into Resource…
33b731e 
…Fetcher. (patchset #1 id:1 of https://codereview.chromium.org/550083003/)

Reason for revert:
This wasn't the root cause of the non-V8 context call.

Original issue's description:
> Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/)
> 
> Reason for revert:
> calls V8 from a non-V8 context
> 
> Original issue's description:
> > Mixed Content: Move subframe checks into ResourceFetcher.
> > 
> > Currently we're checking for mixed content when loading the main
> > resource of subframes in two places: DocumentLoader and ResourceFetcher.
> > The former properly checks against the frame's parent frame, while the
> > latter bypasses the checks entirely by virtue of the request's
> > 'Resource::Type' being 'Main'.
> > 
> > This is both confusing and difficult to replicate when moving to the
> > brave new world of request contexts and frame types that Fetch now
> > defines.
> > 
> > This patch drops the DocumentLoader check, and moves the relevant
> > logic into ResourceFetcher::canRequest and
> > ResourceFetcher::checkInsecureContent.
> > 
> > BUG=400087
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383
> 
> [email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=400087
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181543

[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=400087

Review URL: https://codereview.chromium.org/559333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@jianli-chromium
Revert of CSP: Convert CSPSource constructor bools into a enum. (patc…
5af3948 
…hset #1 id:1 of https://codereview.chromium.org/568433002/)

Reason for revert:
Your patch broke quite a number of webkit tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462

Original issue's description:
> CSP: Convert CSPSource constructor bools into a enum.
> 
> Rather than passing the wildcard disposition of CSPSource's hosts and ports
> as booleans, we should have an enum that allows us to figure out hat we
> mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> order to make this clear.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/565723002

git-svn-id: svn://svn.chromium.org/blink/trunk@181833 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@jianli-chromium
Revert of Revert of CSP: Convert CSPSource constructor bools into a e…
305aaf4 
…num. (patchset #1 id:1 of https://codereview.chromium.org/565723002/)

Reason for revert:
Not a culprit.

Original issue's description:
> Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/)
> 
> Reason for revert:
> Your patch broke quite a number of webkit tests:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462
> 
> Original issue's description:
> > CSP: Convert CSPSource constructor bools into a enum.
> > 
> > Rather than passing the wildcard disposition of CSPSource's hosts and ports
> > as booleans, we should have an enum that allows us to figure out hat we
> > mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> > order to make this clear.
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821
> 
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181833

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/563863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@jianli-chromium
Revert of Revert of Split out CSSParser public API (patchset #1 id:1 of
a6d61db 
https://codereview.chromium.org/566703002/)

Reason for revert:
Bring it back since the OilPan builder is not a tree closer.

Original issue's description:
> Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)
> 
> Reason for revert:
> Caused compiling errors.
> 
> Original issue's description:
> > Split out CSSParser public API
> > 
> > This patch separates the public API of BisonCSSParser from the hundreds
> > of public methods it exposes. The plan is to build a new parser based on
> > the css-syntax specification, which will eventually complete replace the
> > bison-based parser. The functions in this class will do the run-time
> > switching between the bison parser and the new (unwritten) parser.
> > 
> > For the functions here which are only ever used with a newly instantiated
> > BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> > the functions can be static.
> > 
> > This is an updated version of a patch by eseidel from 8 months ago:
> > https://codereview.chromium.org/112933010/
> > 
> > BUG=330389
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825
> 
> [email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181837

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/563893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 12, 2014
@horo-t
Revert of Revert of Service Worker: Add tests for same-scope new scri…
616c521 
…pt registration (patchset #1 id:1 of https://codereview.chromium.org/512703002/)

Reason for revert:
This crash will be fixed by https://codereview.chromium.org/556003006.

Original issue's description:
> Revert of Service Worker: Add tests for same-scope new script registration (patchset #6 of https://codereview.chromium.org/480943002/)
> 
> Reason for revert:
> This is crashing on Mac.
> 
> Original issue's description:
> > Service Worker: Add tests for same-scope, new script registration
> > 
> > Tests for Chromium patch:
> > https://codereview.chromium.org/506043002/
> > 
> > BUG=398355
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948
> 
> [email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=398355
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180956

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398355

Review URL: https://codereview.chromium.org/547743003

git-svn-id: svn://svn.chromium.org/blink/trunk@181878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 14, 2014
Revert of Revert "Remove resetScrollbars" (patchset #1 id:1 of https:…
b8f893e 
…//codereview.chromium.org/534103003/)

Reason for revert:
This was reverted speculatively and was not the cause of the failure.

Original issue's description:
> Revert "Remove resetScrollbars"
> 
> This reverts commit ebcbf43.
> 
> Speculative revert.
> 
> NOTRY=True
> BUG=409708
> [email protected]
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181275

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/568303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 17, 2014
@nico
Revert of Move ChangeVersionWrapper destructor out of line. (patchset #1
6138335 
 id:1 of https://codereview.chromium.org/572343002/)

Reason for revert:
No longer needed, we fixed this in clang instead (see BUG=).

Original issue's description:
> Move ChangeVersionWrapper destructor out of line.
> 
> With clang/win, the vtable of ChangeVersionWrapper ends up being referenced
> for some reason, which causes the destructor to be defined, which requires
> a definition of SQLErrorData. So move the destructor out of line, where
> the definition is available.
> 
> BUG=413478
> [email protected], [email protected]
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182093

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=413478

Review URL: https://codereview.chromium.org/563143005

git-svn-id: svn://svn.chromium.org/blink/trunk@182124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 19, 2014
@horo-t
Revert of Revert of [ServivceWorker] Treat rejecting respondWith as a…
e0dc629 
… Network Error (patchset #1 id:1 of https://codereview.chromium.org/580993002/)

Reason for revert:
Landed the patch to initialize WebServiceWorkerResponse's status.

https://codereview.chromium.org/575153002/

Original issue's description:
> Revert of [ServivceWorker] Treat rejecting respondWith as a Network Error (patchset #4 id:60001 of https://codereview.chromium.org/571843003/)
> 
> Reason for revert:
> WebServiceWorkerResponse's status is not initialised.
> This may cause problems.
> 
> I will re-land this patch after https://codereview.chromium.org/575153002/ is submitted.
> 
> Original issue's description:
> > [ServivceWorker] Treat rejecting respondWith as a Network Error
> > 
> > Chromium side change is this: https://codereview.chromium.org/574643003/
> > 
> > 
> > BUG=411173
> > TEST=layouttest http/tests/serviceworker/
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182147
> 
> [email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=411173
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182204

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=411173

Review URL: https://codereview.chromium.org/585733002

git-svn-id: svn://svn.chromium.org/blink/trunk@182290 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 22, 2014
@caseq
Revert of DevTools: Fix debug_devtools=1 mode "main" extensions loadi…
8733da8 
…ng after r182328 (patchset #1 id:1 of https://codereview.chromium.org/593673002/)

Reason for revert:
Broke the following tests:
inspector/initial-modules-load.html
inspector/open-with-rendering-option-enabled.html

Original issue's description:
> DevTools: Fix debug_devtools=1 mode "main" extensions loading after r182328
> 
> R=dgozman,lushnikov
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182405

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/593703002

git-svn-id: svn://svn.chromium.org/blink/trunk@182409 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 23, 2014
@alancutter
Revert of RenderBlock::layoutPositionedObjects should use setNeedsPos…
8e6e9dd 
…itionedMovementLayout (patchset #1 id:1 of https://codereview.chromium.org/414123006/)

Reason for revert:
Reverting this change fixes stable blocking bug: https://crbug.com/413553

Original issue's description:
> RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout
> 
> This CL swiches RenderBlock::layoutPositionedObjects from using setNeedsLayout
> to setNeedsPositionedMovementLayout, as indicated by the FIXME comment and
> associated bug. The test failure mentioned in the bug is no longer a problem.
> 
> BUG=350756
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179289

[email protected],[email protected],[email protected],[email protected]
BUG=350756,413553

Review URL: https://codereview.chromium.org/598503002

git-svn-id: svn://svn.chromium.org/blink/trunk@182490 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of AX: Calendar Picker: Add a test for input[type=week]. (patc…
bd9f7b1 
…hset #1 id:1 of https://codereview.chromium.org/592003002/)

Reason for revert:
This test is failing consistently on the buildbots. Reverting for now. Can you investigate and reland Kent?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Fcalendar-picker%2Fweek-picker-ax.html&testType=layout-tests

Original issue's description:
> AX: Calendar Picker: Add a test for input[type=week].
> 
> This CL adds a test for Blink r182213 [1] and Chromium #295859 [2].
> 
> [1] http://src.chromium.org/viewvc/blink?view=revision&revision=182213
> [2] https://crrev.com/4968e8da39022d26a07e57eef215612f21cbab10
> 
> BUG=123896
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182548

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=123896

Review URL: https://codereview.chromium.org/601693002

git-svn-id: svn://svn.chromium.org/blink/trunk@182565 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Revert of Initial draft - modify ViewportAnchor to know abo…
aca131c 
…ut both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597113002/)

Reason for revert:
Reapplying, reverting this one shouldn't be necessary.

Original issue's description:
> Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #11 id:200001 of https://codereview.chromium.org/556703005/)
> 
> Reason for revert:
> The new test is failing on mac. Reverting for now so it can be investigated.
> 
> [  FAILED  ] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> [1471/1471] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> Retrying 2 tests (retry #3)
> [ RUN      ] PinchViewportTest.TestResizeAfterVerticalScroll
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> Value of: (pinchViewport.visibleRect().size()).width()
> Actual: 45.94595
> Expected: (FloatSize(50, 25)).width()
> Which is: 50
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> Value of: (pinchViewport.visibleRect().size()).height()
> Actual: 22.972975
> Expected: (FloatSize(50, 25)).height()
> Which is: 25
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:253: Failure
> Value of: (frame()->view()->scrollPosition()).y()
> Actual: 638
> Expected: (IntPoint(0, 625)).y()
> Which is: 625
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:254: Failure
> Value of: (pinchViewport.location()).y()
> Actual: 62
> Expected: (FloatPoint(0, 75)).y()
> Which is: 75
> 
> Original issue's description:
> > Fix pinch virtual viewport position after resize.
> > 
> > Associate the viewport anchor with the inner viewport.
> > Adjust the inner and outer viewport positions after resize
> > such that they both remain in their allowed range and the
> > inner viewport origin scales proportionally within the
> > outer viewport.
> > 
> > As a small cleanup, made the method ScrollView::scrollTo() protected.
> > 
> > BUG=364108
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182365
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=364108
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182580

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=364108

Review URL: https://codereview.chromium.org/597683007

git-svn-id: svn://svn.chromium.org/blink/trunk@182586 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Revert of Revert of Initial draft - modify ViewportAnchor t…
562c11e 
…o know about both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597683007/)

Reason for revert:
Nope: I did have to revert this one. webkit_unit_test failures on mac are back.

Original issue's description:
> Revert of Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597113002/)
> 
> Reason for revert:
> Reapplying, reverting this one shouldn't be necessary.
> 
> Original issue's description:
> > Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #11 id:200001 of https://codereview.chromium.org/556703005/)
> > 
> > Reason for revert:
> > The new test is failing on mac. Reverting for now so it can be investigated.
> > 
> > [  FAILED  ] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> > [1471/1471] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> > Retrying 2 tests (retry #3)
> > [ RUN      ] PinchViewportTest.TestResizeAfterVerticalScroll
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> > Value of: (pinchViewport.visibleRect().size()).width()
> > Actual: 45.94595
> > Expected: (FloatSize(50, 25)).width()
> > Which is: 50
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> > Value of: (pinchViewport.visibleRect().size()).height()
> > Actual: 22.972975
> > Expected: (FloatSize(50, 25)).height()
> > Which is: 25
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:253: Failure
> > Value of: (frame()->view()->scrollPosition()).y()
> > Actual: 638
> > Expected: (IntPoint(0, 625)).y()
> > Which is: 625
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:254: Failure
> > Value of: (pinchViewport.location()).y()
> > Actual: 62
> > Expected: (FloatPoint(0, 75)).y()
> > Which is: 75
> > 
> > Original issue's description:
> > > Fix pinch virtual viewport position after resize.
> > > 
> > > Associate the viewport anchor with the inner viewport.
> > > Adjust the inner and outer viewport positions after resize
> > > such that they both remain in their allowed range and the
> > > inner viewport origin scales proportionally within the
> > > outer viewport.
> > > 
> > > As a small cleanup, made the method ScrollView::scrollTo() protected.
> > > 
> > > BUG=364108
> > > 
> > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182365
> > 
> > [email protected],[email protected],[email protected],[email protected],[email protected]
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=364108
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182580
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=364108
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182586

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=364108

Review URL: https://codereview.chromium.org/601633003

git-svn-id: svn://svn.chromium.org/blink/trunk@182591 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 25, 2014
@jackhou-chromium
Revert of Ship image-rendering: pixelated to stable. (patchset #1 id:…
8458248 
…1 of https://codereview.chromium.org/396063007/)

Reason for revert:
The bug affecting canvases also affects images that become compositor layers. Unshipping until it's fixed.

Original issue's description:
> Ship image-rendering: pixelated to stable.
> 
> This also adds the value to DevTools.
> 
> Intent to Ship:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zSasd2LL8Mc
> 
> BUG=317991,106662,260739,134040
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178653

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=317991,106662,260739,134040

Review URL: https://codereview.chromium.org/604683003

git-svn-id: svn://svn.chromium.org/blink/trunk@182649 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 29, 2014
@zhenyao
Revert of Expose IA and IA2 role and state for HTML input type attrib…
0c6b223 
…utes related to date and time. (patchset #1 id:1 of https://codereview.chromium.org/612063002/)

Reason for revert:
This likely broke DumpAccessibilityTreeTest.AccessibilityInputTime in
content_browsertest

Original issue's description:
> Expose IA and IA2 role and state for HTML input type attributes related to date and time.
> 
> For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states
> are not exposed properly.
> 
> BUG=418486
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182848

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=418486

Review URL: https://codereview.chromium.org/609403005

git-svn-id: svn://svn.chromium.org/blink/trunk@182863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 30, 2014
Revert of Remove unused sourceData variable in InspectorStyleSheet. (…
9b220aa 
…patchset #1 id:1 of https://codereview.chromium.org/574963002/)

Reason for revert:
This code is still needed

Original issue's description:
> Remove unused sourceData variable in InspectorStyleSheet.
> 
> Breaks build for targets that treat unused variables as errors.
> 
> [email protected], [email protected]
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182145

[email protected],[email protected]

Review URL: https://codereview.chromium.org/611333002

git-svn-id: svn://svn.chromium.org/blink/trunk@182928 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nwtn